[
https://issues.apache.org/jira/browse/CHUKWA-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501456#comment-13501456
]
Hudson commented on CHUKWA-642:
-------------------------------
Integrated in Chukwa-trunk #460 (See
[https://builds.apache.org/job/Chukwa-trunk/460/])
CHUKWA-642. Added regular expression validation. (Eric Spishak via Eric
Yang) (Revision 1411833)
CHUKWA-642. Added regular expression validation. (Eric Spishak via Eric Yang)
(Revision 1411813)
Result = SUCCESS
eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411833
Files :
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/util/RegexUtil.java
eyang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1411813
Files :
* /incubator/chukwa/trunk/CHANGES.txt
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/database/DataExpiration.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/database/TableCreator.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/datacollection/writer/SocketTeeWriter.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/dataloader/MetricDataLoader.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/extraction/demux/processor/mapper/TsProcessor.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/inputtools/ChukwaInputFormat.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/util/DumpChunks.java
*
/incubator/chukwa/trunk/src/main/java/org/apache/hadoop/chukwa/util/Filter.java
*
/incubator/chukwa/trunk/src/test/java/org/apache/hadoop/chukwa/extraction/demux/processor/mapper/TestTsProcessor.java
*
/incubator/chukwa/trunk/src/test/java/org/apache/hadoop/chukwa/inputtools/TestInputFormat.java
*
/incubator/chukwa/trunk/src/test/java/org/apache/hadoop/chukwa/util/TestDumpChunks.java
*
/incubator/chukwa/trunk/src/test/java/org/apache/hadoop/chukwa/util/TestFilter.java
> Unvalidated Regular Expression Usage
> ------------------------------------
>
> Key: CHUKWA-642
> URL: https://issues.apache.org/jira/browse/CHUKWA-642
> Project: Chukwa
> Issue Type: Bug
> Components: Build and Test Code, Data Collection, MR Data Processors
> Affects Versions: 0.3.0, 0.4.0, 0.5.0
> Reporter: Eric Spishak
> Assignee: Eric Spishak
> Fix For: 0.6.0
>
> Attachments: CHUKWA-642-1.patch, CHUKWA-642-2.patch, CHUKWA-642.patch
>
>
> There are seven additional places in Chukwa where regular expressions are
> used without first being validated as syntactically valid regular
> expressions. These could lead to unhelpful PatternSyntaxException strack
> traces instead of useful error messages. Unfortunately, I was not able to
> produce test conditions to highlight any of these issues.
> The attached patch fixes the issues. Note that the patch adds a small
> RegexUtil class with helper methods to determine whether a String is a valid
> regular expression and to generate error messages for invalid regular
> expressions. I feel that these helper methods are more readable than catching
> the PatternSyntaxException. Furthermore, they allow simpler re-use if needed
> elsewhere.
> I discovered these bugs using a tool named the Regex Checker
> ([http://types.cs.washington.edu/checker-framework/current/checkers-manual.html#regex-checker]).
> If you periodically run it on your codebase, then you will learn of other
> errors like this as soon as they appear. If you are interested, I can share
> my annotations for Chukwa, which will enable you to run the Regex Checker
> yourself without any additional effort.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
