[
https://issues.apache.org/jira/browse/CHUKWA-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637597#comment-13637597
]
Eric Yang commented on CHUKWA-686:
----------------------------------
Can you generate another patch without white space indent changes? It would be
good to retain existing indentation to follow Chukwa coding style. (Sun's code
conventions except indentation is 2 spaces, not 4)
The rest of the patch looks fine. Thanks
> Creating a new adaptor: FileTailingAdaptorPreserveLines
> -------------------------------------------------------
>
> Key: CHUKWA-686
> URL: https://issues.apache.org/jira/browse/CHUKWA-686
> Project: Chukwa
> Issue Type: Improvement
> Components: Data Collection
> Reporter: Sourygna Luangsay
> Assignee: Sourygna Luangsay
> Priority: Minor
> Fix For: 0.6.0
>
> Attachments: chukwa-686.patch
>
>
> FileTailingAdaptor is great to tail log files and send them to Hadoop.
> However, last line of the chunk is usually cut which leads to some errors.
> CharFileTailingAdaptorUTF8 can solve such problem.
> Nonetheless, this adaptor calls the MapProcessor.process() method for every
> line in each chunk, thus slowing a lot the Demux phase.
> FileTailingAdaptorPreserveLines adaptor mixes the benefits of the two
> adaptors: the (Demux) speed of FileTailingAdaptor and
> the preservation of lines from CharFileTailingAdaptorUTF8.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
