The GitHub Actions job "C++ Linter" on iceberg-cpp.git/SnapshotUpdate has 
failed.
Run started by GitHub user shangxinli (triggered by shangxinli).

Head commit for run:
4e37cbf550dc3c155a0792fc1844e95968dd8062 / Xinli Shang <[email protected]>
feat: add missing methods to SnapshotUpdate interface

Add DeleteWith() and ToBranch() methods to complete the SnapshotUpdate API
coverage from Java implementation. This brings the interface closer to
feature parity with Java Iceberg.

New methods:
- DeleteWith(): Set custom file deletion callback for tracking deleted files,
  implementing custom retention policies, or delegating deletion to external
  systems. Uses std::function<void(std::string_view)> for the callback.

- ToBranch(): Commit snapshot to a specific branch instead of main branch.
  Useful for Write-Audit-Publish (WAP) workflows, feature branch development,
  and testing changes before merging to main.

Method deferred:
- ScanManifestsWith(): Deferred until executor/thread pool infrastructure is
  available in the codebase. Documented in class comments for future addition.

Changes:
- Add DeleteWith() and ToBranch() methods with fluent API
- Add delete_func_ and target_branch_ protected members
- Add 3 new test cases: DeleteWith, ToBranch, MethodChainingWithAllMethods
- Update class documentation to list included and deferred methods
- Total test count increased from 10 to 13, all passing

Report URL: https://github.com/apache/iceberg-cpp/actions/runs/19711266412

With regards,
GitHub Actions via GitBox

Reply via email to