The GitHub Actions job "Spark CI" on iceberg.git/main has succeeded.
Run started by GitHub user nastra (triggered by nastra).

Head commit for run:
bd96b79b4229f27c0aa4a0ed776a1493499cfd79 / Eduard Tudenhoefner 
<[email protected]>
Core, Hive: Detect if a view already exists when registering a table (#15010)

This was already working for all catalogs that support views, except for the 
`HiveCatalog`.
All catalogs already had some logic that would perform table/view conflict 
detection when committing metadata in their `doCommit()` methods.
However, the `HiveCatalog` currently does view/table detection one step 
earlier, namely when `doRefresh()` is called in 
https://github.com/apache/iceberg/blob/cbd35799dc70e989528b1c14d640fe91cdafa52d/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java#L175-L177.
One alternative would be to override `registerTable()` for view catalgos and 
add early view detection (before metadata is actually committed). However, that 
would also require overriding table registration in the `JDBCCatalog` in order 
to detect whether view support is available or not.
Hence it's probably best to only override table registration in the 
`HiveCatalog`

Report URL: https://github.com/apache/iceberg/actions/runs/20985019942

With regards,
GitHub Actions via GitBox

Reply via email to