On Thu, 2015-02-19 at 00:37 +0000, Tarun Chopra wrote: > Hello Andrew - > > Thanks for the feedback. > > Just below this section 4.1.6.2.1 in section 4.1.6.3, we have provided > forward reference to section 6.2.2 of MS-ADTS. In addition, last step of > pseudo code provided in section 4.1.6.3 calls into 'ExecuteKCCTasks()' which > gives an impression that both sections are linked. Is it sufficient from > implementation\clarity point of view to have reference from section 4.1.6.3 > only ? If not, we will go ahead and add the reference in section 4.1.6.2.1 > too. > > 4.1.6.3 Server Behavior of the IDL_DRSExecuteKCC Method > ........ See [MS-ADTS] section 6.2.2 for more information related to > the tasks performed by the KCC upon receipt of an IDL_DRSExecuteKCC request. > > ULONG > IDL_DRSExecuteKCC( > ... > ... > return ExecuteKCCTasks()
I did miss that reference. Thanks. However, I do think we need a bit more - the transition between paragraphs and pseudo-code in the docs is always a bit jarring, but it is particularly so when it is an inter-doc reference to something that starts with a much more general description. Perhaps fill in ExecuateKCCTasks with this list from 6.2.2, referencing each of the tasks by number individually? Refresh kCCFailedLinks and kCCFailedConnections. Create intra-site connections. Create inter-site connections. Remove unnecessary connections. Translate connections. Remove unnecessary kCCFailedLinks and kCCFailedConnections. Thanks, Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba _______________________________________________ cifs-protocol mailing list [email protected] https://lists.samba.org/mailman/listinfo/cifs-protocol
