On Tue, Dec 22, 2009 at 11:20:18AM -0500, Elnatan Reisner wrote: > On Dec 16, 2009, at 3:12 AM, Gabriel Kerneis wrote: > >On Tue, Dec 15, 2009 at 09:26:24PM -0500, Elnatan Reisner wrote: > >>I tested this out on a few small examples that triggered the bug; if > >>anyone wants to see those examples, let me know. > >It would be nice if you could include them in the test suite. > I'm not exactly clear on the structure of the test suite, and I'm > not sure I can commit to the repository (can I?).
No, you can't, and neither can I by the way. I maintain a clone of the CIL svn using git, with a "patches" branch where I store fixes I hope to get included upstream some day. If you want to grab it: # The master branch is upstream. The cpc branch is my PhD project. git clone -b patches http://www.pps.jussieu.fr/~kerneis/software/repos/cpc.git cil # Since git doesn't handle externals, there is a separate repo for # ocamlutil. It contains some patches too. Once again, master is # upstream. cd cil git clone -b patches http://www.pps.jussieu.fr/~kerneis/software/repos/ocamlutil.git It would be nice if upstream had time to include them, but I guess they are very busy at the moment since most of those patches have been sent to the mailing-list and got no answer. > Instead, I'm attaching four test files which cause label-naming > errors; maybe you can put them in the test suite. I added your patch and test files to the "patches" branch. Thank you very much. By the way, if anyone on the mailing-list also has patches for CIL, I would be glad to add them and get them upstream eventually. NB: for those of you who are not familiar with git, you can update with "git pull" (in both cil/ and cil/ocamlutil) and get a list of patches (in /tmp) with "git format-patch -o /tmp remotes/origin/master" (do not forget to execute it in both cil/ and cil/ocamlutil). Regards, -- Gabriel Kerneis ------------------------------------------------------------------------------ Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev _______________________________________________ CIL-users mailing list CIL-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cil-users
