On Tue, Feb 15, 2011 at 10:10:46AM -0500, Elnatan Reisner wrote: > I haven't thought hard about this, but it looks to me like the key > in the cases where result is not used is just that the cast is not > inserted, so I think you should still used the 'rolled' type---that > is, the input [nt], rather than [unrollType nt]. Two of the changes > you made affect error messages; I don't know what would be more > understandable, but I would think reporting the typedef'ed name > would be better. Also, in the TComp case where a recursive call is > made to castTo, I would think that this case, too, should use the > input [nt] rather than the unrolled type. But, as I said, I haven't > thought very hard about this.
Agreed, this makes sense. I looked for a counter-example but couldn't find any, so I just reverted my changes to keep typedefs in the output everywhere. If someone has trouble with it some day, at least the commit will be easy to single out. CIL's svn seems to be down at the moment, but I'll push this as soon as it is brought back to life. Best, -- Gabriel ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ CIL-users mailing list CIL-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/cil-users
