I made those commits into new series,  you probably want to rename this to
0009-*.patch... I do not think old 0008 patch will do any good -
GReen-BLue-REd planar float format is not something Cin easily can convert
for internal use (I saw similar comment in oiio sources... I am not good
enough for adding even simple format to ffmpeg/swscale.. even with already
written examples)

from

https://github.com/OpenImageIO/oiio/blob/master/src/ffmpeg.imageio/ffmpeginput.cpp

case AV_PIX_FMT_GBRPF32BE:
    case AV_PIX_FMT_GBRPF32LE:
        nchannels = 3;
        datatype = TypeFloat;
        m_dst_pix_format = AV_PIX_FMT_RGB48; // ? AV_PIX_FMT_GBRPF32
        // FIXME: They don't have a type for RGB float, only GBR float.
        // Yuck. Punt for now and save as uint16 RGB. If people care, we
        // can return and ask for GBR float and swap order.
        break;



On Wednesday, July 14, 2021, Andrea paz <[email protected]> wrote:

> I tried to compile with the two patches 0007 and 0008, but the
> compilation gives an error. I append the cin5.log, if it helps.
>
From a18f62c4528ea90417edeb1c97da15278cc0c195 Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu <[email protected]>
Date: Wed, 14 Jul 2021 21:25:10 +0300
Subject: [PATCH 6/6] Forgot to alter colorspace plugin for bt2020 split

---
 cinelerra-5.1/plugins/colorspace/colorspace.C | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/cinelerra-5.1/plugins/colorspace/colorspace.C b/cinelerra-5.1/plugins/colorspace/colorspace.C
index 52126aa6..bb1a7b38 100644
--- a/cinelerra-5.1/plugins/colorspace/colorspace.C
+++ b/cinelerra-5.1/plugins/colorspace/colorspace.C
@@ -315,14 +315,16 @@ void XTable::init(int len, int inv,
 	case BC_COLORS_BT601_NTSC:  iKr = BT601_NTSC_Kr;   iKb = BT601_NTSC_Kb;   break;
 	case BC_COLORS_BT601_PAL:  iKr = BT601_PAL_Kr;   iKb = BT601_PAL_Kb;   break;
 	case BC_COLORS_BT709:  iKr = BT709_Kr;   iKb = BT709_Kb;   break;
-	case BC_COLORS_BT2020: iKr = BT2020_Kr;  iKb = BT2020_Kb;  break;
+	case BC_COLORS_BT2020_NCL: 
+	case BC_COLORS_BT2020_CL: iKr = BT2020_Kr;  iKb = BT2020_Kb;  break;
 	}
 	switch( out_space ) {
 	default:
 	case BC_COLORS_BT601_NTSC:  oKr = BT601_NTSC_Kr;   oKb = BT601_NTSC_Kb;   break;
 	case BC_COLORS_BT601_PAL:  oKr = BT601_PAL_Kr;   oKb = BT601_PAL_Kb;   break;
 	case BC_COLORS_BT709:  oKr = BT709_Kr;   oKb = BT709_Kb;   break;
-	case BC_COLORS_BT2020: oKr = BT2020_Kr;  oKb = BT2020_Kb;  break;
+	case BC_COLORS_BT2020_NCL: 
+	case BC_COLORS_BT2020_CL: oKr = BT2020_Kr;  oKb = BT2020_Kb;  break;
 	}
 
 	int iyuv = BC_CModels::is_yuv(inp_model);
-- 
2.32.0

-- 
Cin mailing list
[email protected]
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Reply via email to