Hopefully filetga check for invalid file (header bpp will be random)

On Sun, Aug 27, 2023 at 11:33 PM Andrew Randrianasulu
<randrianas...@gmail.com> wrote:
>
> On Sun, Aug 27, 2023 at 11:29 PM Andrea paz <gamberucci.and...@gmail.com> 
> wrote:
> >
> > In my opinion, it depends on putting the images in /tmp. When I
> > changed the destination folder (/home/test) I had no more problems.
> > Try setting up CinGG with a different brender destination folder; one
> > that is not with root privileges.
>
> I tried to runtime sitch brender type while using same /tmp (/dev/shm/tmp) 
> dir.
>
> I got few crashes.
>
> Tried to fix two cases (tiff and png), filetga still crashes.
>
> Can you check this patch with normal file load and also bg renders?
>
> >
> > PS: I had not responded to this request of yours:
> > > Are those errors with my patch and normal single-user build, or they only 
> > > appear in appimage (with my patch?)
> > All those warnings are from the build with your patches. But the vaapi
> > decoder works fine.
> >
> > The vaapi decoder failure errors only affect the appimage (from 2
> > months ago --> no patch). Those numerous warnings are not present
> > here, though.
From c444679ac7ea45862c9d6a17ce8188a8b44aaf02 Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu <randrianas...@gmail.com>
Date: Sun, 27 Aug 2023 23:55:46 +0300
Subject: [PATCH 2/2] Add check/return for filetga reading (check bpp, return
 on non 24/32)

---
 cinelerra-5.1/cinelerra/filetga.C | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cinelerra-5.1/cinelerra/filetga.C b/cinelerra-5.1/cinelerra/filetga.C
index df9a56ee..0bff2e18 100644
--- a/cinelerra-5.1/cinelerra/filetga.C
+++ b/cinelerra-5.1/cinelerra/filetga.C
@@ -337,6 +337,8 @@ void FileTGA::read_tga(Asset *asset, VFrame *frame, VFrame *data, VFrame* &temp)
 		case 24:
 			source_cmodel = BC_RGB888;
 			break;
+		default:
+			return;
 	}
 
 // Read image
-- 
2.35.7

-- 
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Reply via email to