added as git diff file attached to this mail.

I am not sure that consensus was, but I see even dvd can contain up to 7.1
audio, and even this mpeg multichannel encoder I just rediscovered had some
support/experiments in this direction,  in 1990s)



вс, 22 нояб. 2020 г., 16:00 Pierre autourduglobe via Cin <
[email protected]>:

> I don't think we should arbitrarily limit Cinélerra-GG's ability to use
> and display track/ch sound.
>
> Cin-GG presents itself as an NLE for pro-users or professional users. If
> a new model of sound environment (more channels) is introduced, it is
> certain that daring users will want to experiment with it and Cin-GG
> should allow it.
>
> To the extent that it is possible to keep track/ch management and
> display easy, I don't think we should limit them simply to what is
> currently the most common...
>
> Pierre
>
>
> Le 20-11-22 à 04 h 32, Andrew Randrianasulu via Cin a écrit :
> > В сообщении от Sunday 22 November 2020 11:39:25 Igor BEGHETTO via Cin
> написал(а):
> >> Andrew, thanks for confirm the code about.
> >> Yes it is true, you can delete audio tracks and change number of
> >> channels in Setting->Format, and use GangChannel/GangMedia. As you saw
> >> in my example CinelerraGG always create all audio tracks that the clip
> >> contains (in the example there are empty audio tracks) and that is
> >> right. Audio Channels are not audio tracks and I would leave max
> >> channels to 6. I think it may be a good standard when there are more
> >> than 6 channels.
> >
> > There is 7.1 setup on my audiocard:
> >
> > aplay -L
> > null
> >      Discard all samples (playback) or generate zero samples (capture)
> > jack
> >      JACK Audio Connection Kit
> > sysdefault:CARD=SB
> >      HDA ATI SB, ALC892 Analog
> >      Default Audio Device
> > front:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      Front speakers
> > surround21:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      2.1 Surround output to Front and Subwoofer speakers
> > surround40:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      4.0 Surround output to Front and Rear speakers
> > surround41:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      4.1 Surround output to Front, Rear and Subwoofer speakers
> > surround50:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      5.0 Surround output to Front, Center and Rear speakers
> > surround51:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      5.1 Surround output to Front, Center, Rear and Subwoofer speakers
> > surround71:CARD=SB,DEV=0
> >      HDA ATI SB, ALC892 Analog
> >      7.1 Surround output to Front, Center, Side, Rear and Woofer speakers
> >
> >
> > Anyway, my point was you can't see if track/ch is empty or full before
> you load it.
> > In unmodified case you better to check media info in asset window and
> then
> > abjust channels for newly-created project. Some manual work.
> >
> > Also,  using same define for all codebase allow you to change things in
> one
> > central place, without remembering this special number in this specific
> file.
> >
> > And finally, my change shouldn't affect your usual files. And really
> pathological/broken
> > files with 1000 channels still will be cut down to reasonable amount of
> channels.
> > You can manipulate all tracks via GUI, but this *6* number must be
> changed in code and Cin recompiled -
> > some time on user end, if user will be curious enough to investigate
> this limitation.
> >
> > But again, I can carry this patch locally and dealt with consequences
> too ...
> >
> >>
> >> Phyllis wrote:
> >>> For now, which could change at any minute, I would like to continue to
> >>> test mods as a check on my laptop as I had been doing and attempt to
> >>> check them into GIT.  I will let you know how this goes.
> >> Phyllis, I am glad you are here. Thanks!
> >>
> >> IgorBeg
> >
> >
> --
> Cin mailing list
> [email protected]
> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>
From 8c389c577e67672e193cb1c83a51c3dc3037bbba Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu <[email protected]>
Date: Wed, 17 Jan 2024 00:08:47 +0300
Subject: [PATCH] Use maxchannels define in mwindow.C

---
 cinelerra-5.1/cinelerra/mwindow.C | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cinelerra-5.1/cinelerra/mwindow.C b/cinelerra-5.1/cinelerra/mwindow.C
index 7124395e..1291b992 100644
--- a/cinelerra-5.1/cinelerra/mwindow.C
+++ b/cinelerra-5.1/cinelerra/mwindow.C
@@ -5304,7 +5304,7 @@ int MWindow::select_asset(Asset *asset, int vstream, int astream, int delete_tra
 		int channels = 0;
 		for( uint64_t mask=channel_mask; mask!=0; mask>>=1 ) channels += mask & 1;
 		if( channels < 1 ) channels = 1;
-		if( channels > 6 ) channels = 6;
+		if( channels > MAXCHANNELS ) channels = MAXCHANNELS;
 		session->audio_tracks = session->audio_channels = channels;
 
 		int *achannel_positions = preferences->channel_positions[session->audio_channels-1];
-- 
2.43.0

-- 
Cin mailing list
[email protected]
https://lists.cinelerra-gg.org/mailman/listinfo/cin

Reply via email to