Please try attached patches - first fixes aging window sliders so they show latest changes over configure window close/reopen cycle Second patch mods againg.C so processing for pits/dust happens only if param > 0 (not sure if such change desirable?)
On Thu, Feb 29, 2024 at 10:08 AM Andrew Randrianasulu < [email protected]> wrote: > > > ср, 28 февр. 2024 г., 20:37 Phyllis Smith via Cin < > [email protected]>: > >> (ometimes I just can not stop myself and just had to look at AgingTV.) I >> think I found the problem. If everything is unchecked and then one of the >> 3 items of Scratch, Pits, or Dust is checked BUT set to zero, you can still >> see that item in the compositor. Grain is either on or off and works as >> expected. >> > > > Einar added few commits to cin-cve version of plugin: > > https://github.com/vanakala/cinelerra-cve/commits/master/plugins/aging > > "Fixed applying of AgingTV pits" > > "New function AgingConfig::boundaries > > Checks the limits of configuration parameters > Area_scale and dust_interval can't be zero > > " > > >> The good news is that at least you can designate which type of aging you >> want, be it grain, scratch, pits, dust, or all or none. I will log a BT on >> this in case anyone wants to look at it in the future. >> >> -- >> Cin mailing list >> [email protected] >> https://lists.cinelerra-gg.org/mailman/listinfo/cin >> >
From 99f324b76997097e571f2e637b739b5381edb6cc Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Sun, 21 Apr 2024 11:45:15 +0300 Subject: [PATCH 1/2] Save value of agingwindow sliders by using get_value(). --- cinelerra-5.1/plugins/aging/agingwindow.C | 1 + 1 file changed, 1 insertion(+) diff --git a/cinelerra-5.1/plugins/aging/agingwindow.C b/cinelerra-5.1/plugins/aging/agingwindow.C index 5f4007aa..9ccb4d8a 100644 --- a/cinelerra-5.1/plugins/aging/agingwindow.C +++ b/cinelerra-5.1/plugins/aging/agingwindow.C @@ -82,6 +82,7 @@ AgingISlider::~AgingISlider() int AgingISlider::handle_event() { int ret = BC_ISlider::handle_event(); + *output = get_value(); win->plugin->send_configure_change(); return ret; } -- 2.35.8
From 49a6d85161ed3d26cb0b56986e393768d601d76e Mon Sep 17 00:00:00 2001 From: Andrew Randrianasulu <[email protected]> Date: Sun, 21 Apr 2024 11:46:39 +0300 Subject: [PATCH 2/2] Only process agingTV dust/pits if value > 0 --- cinelerra-5.1/plugins/aging/aging.C | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cinelerra-5.1/plugins/aging/aging.C b/cinelerra-5.1/plugins/aging/aging.C index 5517b44d..41d30d75 100644 --- a/cinelerra-5.1/plugins/aging/aging.C +++ b/cinelerra-5.1/plugins/aging/aging.C @@ -581,12 +581,12 @@ void AgingClient::process_package(LoadPackage *package) plugin->input_ptr->get_color_model(), plugin->input_ptr->get_w(), local_package->row2 - local_package->row1); - if( plugin->config.pits ) + if( plugin->config.pits && plugin->config.pits_interval > 0 ) pits(output_rows, plugin->input_ptr->get_color_model(), plugin->input_ptr->get_w(), local_package->row2 - local_package->row1); - if( plugin->config.dust ) + if( plugin->config.dust && plugin->config.dust_interval > 0 ) dusts(output_rows, plugin->input_ptr->get_color_model(), plugin->input_ptr->get_w(), -- 2.35.8
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
