ср, 2 апр. 2025 г., 12:46 Andrew Randrianasulu <randrianas...@gmail.com>:
>
>
> пн, 31 мар. 2025 г., 16:34 Andrea paz via Cin <cin@lists.cinelerra-gg.org
> >:
>
>> Obviously it was my fault: I had not removed the clip in Blend Program....
>> I re-tested and most of the color-related plugins do not have
>> clipping. Unfortunately (at least for me) some of the most important
>> plugins have it:
>>
>> Blur
>>
>
> Try to look for switch(color) in plugins/blur/blur.C
>
> and replace for testing 1.0 for rgba/rgb float cases with FLT_MAX ? Like
> in our earlier work ....
>
> case BC_RGBA_FLOAT:
> BLUR(float, 1.0, 4);
> break;
>
> If it does not break plugin we probably can go for each noted plugin and
> try to find where they clip ....
>
may be like attached patch? Only blur and titler converted, do not want to
break vectoroscope etc
>
> Color 3 Way
>> Color Space
>> Foreground
>> Histogram
>> Histogram Bezier
>> Title
>> Videoscope
>>
>> I remember an attempt by Andrew with Adam to try to engage him on the
>> Histogram clipping, but Adam was not really interested:
>> https://github.com/heroineworshiper/hvirtual/issues/8
>>
>> @Phyllis
>> Do you think it's good to indicate in the manual the plugins that do
>> the clipping?
>> --
>> Cin mailing list
>> Cin@lists.cinelerra-gg.org
>> https://lists.cinelerra-gg.org/mailman/listinfo/cin
>>
>
From 25bc934759ac2c7953ccbd7f1e45bd52c8d8a5be Mon Sep 17 00:00:00 2001
From: Andrew Randrianasulu <randrianas...@gmail.com>
Date: Wed, 2 Apr 2025 12:52:03 +0300
Subject: [PATCH] Experimental: remove clipping from blur/titler plugins?
---
cinelerra-5.1/plugins/blur/blur.C | 6 +++---
cinelerra-5.1/plugins/titler/titler.C | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cinelerra-5.1/plugins/blur/blur.C b/cinelerra-5.1/plugins/blur/blur.C
index dfbf501c..e904f878 100644
--- a/cinelerra-5.1/plugins/blur/blur.C
+++ b/cinelerra-5.1/plugins/blur/blur.C
@@ -32,7 +32,7 @@
#include <string.h>
-
+#define MAX_FLT 3.40282347e+38
#define MIN_RADIUS 2
@@ -573,7 +573,7 @@ void BlurEngine::run()
break;
case BC_RGB_FLOAT:
- BLUR(float, 1.0, 3);
+ BLUR(float, MAX_FLT, 3);
break;
case BC_RGBA8888:
@@ -582,7 +582,7 @@ void BlurEngine::run()
break;
case BC_RGBA_FLOAT:
- BLUR(float, 1.0, 4);
+ BLUR(float, MAX_FLT, 4);
break;
case BC_RGB161616:
diff --git a/cinelerra-5.1/plugins/titler/titler.C b/cinelerra-5.1/plugins/titler/titler.C
index b4157811..7ebbfaec 100644
--- a/cinelerra-5.1/plugins/titler/titler.C
+++ b/cinelerra-5.1/plugins/titler/titler.C
@@ -2306,9 +2306,9 @@ void TitleTranslateUnit::process_package(LoadPackage *package)
switch( output->get_color_model() ) {
case BC_RGB888: TRANSLATE(unsigned char, 0xff, 3, 0); break;
- case BC_RGB_FLOAT: TRANSLATE(float, 1.0, 3, 0); break;
+ case BC_RGB_FLOAT: TRANSLATE(float, MAX_FLT, 3, 0); break;
case BC_YUV888: TRANSLATE(unsigned char, 0xff, 3, 0x80); break;
- case BC_RGBA_FLOAT: TRANSLATE(float, 1.0, 4, 0); break;
+ case BC_RGBA_FLOAT: TRANSLATE(float, MAX_FLT, 4, 0); break;
case BC_RGBA8888: TRANSLATE(unsigned char, 0xff, 4, 0); break;
case BC_YUVA8888: TRANSLATE(unsigned char, 0xff, 4, 0x80); break;
}
--
2.48.1
--
Cin mailing list
Cin@lists.cinelerra-gg.org
https://lists.cinelerra-gg.org/mailman/listinfo/cin
