Banal mistake i made when beautifying the code.
where are those damn unit tests now!
bye
andraz
On čet, 2006-04-06 at 19:56 +0200, Andraz Tori wrote:
> Ok... I've fixed the problem... since i have caused it at the first
> place when fixing already broken code when trying to do correct
> drag'n'drop on timeline...
>
> now it should work ok!
>
> (we really miss unit tests... the real maschochist please stand up,
> please stand up!)
>
> bye
> andraz
>
>
> On tor, 2006-03-07 at 18:13 -0500, Dan Streetman wrote:
> > Yep, I had (have...) the same problem. I don't think it's tweaking while
> > playing back tho, as it's happened many times to me and I always stop
> > playback before tweaking. I don't really know what's causing it.
> > It's certainly annoying as hell.
> >
> > What I did to fix the "broken" xml file was create a sed script-file
> > containing:
> > s,<PLUGIN LENGTH="0" TYPE="0"
> > TITLE=""><IN></IN><OUT></OUT><ON></ON><KEYFRAME POSITION="[[:digit:]]*"
> > DEFAULT="1"></KEYFRAME></PLUGIN>,,g
> >
> > and run the xml file through it:
> > cat file.xml | tr -d '\n' | sed -f sedscriptfile > fixed.xml
> >
> > although using perl should work fine too.
> >
> >
> > On Tue, 7 Mar 2006, Brendan Conoboy wrote:
> >
> > >Hi everyone,
> > >
> > >As a novice cinelerra user, I've run into a heinous problem every now
> > >and again. After doing some work on a video, I'll save, do some more,
> > >save.... for a day or two. Normally when I start up again, the xml file
> > >is a few dozen to a few hundred k. Every now and again, it's 5
> > >megabytes large, fails to load, and makes me weep in an unmanly way
> > >(tm). The physical characteristic of the problem appears to be null
> > >keyframes being inserted into the xml file, like this:
> > >
> > ><PLUGIN LENGTH="0" TYPE="0" TITLE="">
> > ><IN></IN><OUT></OUT><ON></ON>
> > ><KEYFRAME POSITION="0" DEFAULT="1"></KEYFRAME>
> > ></PLUGIN>
> > >
> > >Thousands of them. Tens of thousands. Hundreds of thousands of them.
> > >
> > >As to where they come from, it appears to be the result of tweaking
> > >plugin parameters *while* cinelerra is doing playback. I've not
> > >investigated this problem, but I do have a bandaid of a solution,
> > >written in perl:
> > >
> > >#!/usr/bin/perl
> > >while($_=<STDIN>)
> > > {
> > > if ( $_ =~ /PLUGIN LENGTH="0"/ )
> > > {
> > > $skipped=0;
> > > while($skipped==0)
> > > {
> > > $_=<STDIN>;
> > > if ( $_ =~ /\/PLUGIN/ ) { $skipped=1; }
> > > }
> > > }
> > > print $_;
> > >}
> > >
> > >To use it, just save it as 'unexplode', make it executable and use
> > >"unexplode < bloated.xml > lean.xml" to strip out all plugins of length
> > >0. Hopefully there aren't any desirable plugins of length 0!
> > >
> > >-Brendan
> > >
> > >_______________________________________________
> > >Cinelerra mailing list
> > >[email protected]
> > >https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
> > >
> >
--- hvirtual-cvs/cinelerra/edits.C 2006-04-06 19:58:35.000000000 +0200
+++ hvirtual-2/cinelerra/edits.C 2006-04-06 20:27:03.000000000 +0200
@@ -232,7 +232,6 @@
Edit *new_edit = create_edit();
insert_after(edit, new_edit);
- new_edit->startproject = position;
if (edit) // if we have actually split the edit, do the funky stuff!
{
new_edit->copy_from(edit);
@@ -252,7 +251,7 @@
new_edit->transition->length = new_edit->length;
} else
new_edit->length = 0;
-
+ new_edit->startproject = position;
return new_edit;
