Another regression caused by me.. here's the fix

On pet, 2006-04-07 at 00:32 +0200, Andraz Tori wrote:
> Ah, i finally get the point... yes i can reproduce it now too.. will try
> to fix soon ...
> 
> bye
> andraz
> 
> On čet, 2006-04-06 at 20:59 +0200, streumix wrote:
> > Andraz,
> > 
> > to reproduce the crash, I simply need to start up cinelerra
> > with default setting  (on customization / new user accout),
> > load  a clip ( I've only tested DV in avi or mov container so far ),
> > select some part or all of it, and call render effect.
> > You can choose any effect and probably any output format.
> > Bingo. Crash !
> > 
> > There's no difference in using the optimized athlonxp or basic
> > sid packages. (I've tested latest 2.0.0-1svn20060406,sid)
> > 
> > Is your system in sync with debian unstable or experiemental ?
> > 
> > My libc6 is 2.3.6-5, gcc (libgcc, etc.) is 4.0.3, libdv4 is 0.104-2.
> > Any other wrong libs versions that's might cause the crash ?
> > 
> > Toby
> > 
> > PS: oh... I almost forgot to append the console output for a crash:
> > 
> > signal_entry: got SIGSEGV my pid=8173 execution table size=92:
> >     VRender::run 0
> >     VRender::run 0.1
> >     VRender::run 0.2
> >     vrender.C: process_buffer: 109
> >     vrender.C: process_buffer: 116
> >     vrender.C: get_colormodel: 323
> >     vrender.C: get_colormodel: 326
> >     vrender.C: process_buffer: 119
> >     vrender.C: process_buffer: 124
> >     vrender.C: process_buffer: 171
> >     virtualvconsole.C: process_buffer: 60
> >     virtualvconsole.C: process_buffer: 71
> >     virtualvconsole.C: process_buffer: 75
> >     virtualvnode.C: render: 137
> >     virtualvnode.C: render_as_module: 186
> >     virtualvnode.C: read_data: 86
> >     virtualvnode.C: read_data: 89
> >     module.C: update_transition: 218
> >     module.C: update_transition: 225
> >     module.C: update_transition: 235
> >     vmodule.C: render: 365
> >     vmodule.C: render: 370
> >     vmodule.C: render: 446
> >     vmodule.C: import_frame: 93
> >     vmodule.C: import_frame: 101
> >     vmodule.C: import_frame: 115
> >     file.C: open_file: 313
> >     vmodule.C: import_frame: 117
> >     vmodule.C: import_frame: 137
> >     vmodule.C: import_frame: 182
> >     vmodule.C: import_frame: 240
> >     vmodule.C: import_frame: 242
> >     vmodule.C: import_frame: 316
> >     vmodule.C: render: 452
> >     virtualvnode.C: render_as_module: 204
> >     virtualvnode.C: render_as_module: 211
> >     virtualvnode.C: render_as_module: 221
> >     virtualvnode.C: render_as_module: 238
> >     virtualvnode.C: render_as_module: 248
> >     virtualvnode.C: render: 142
> >     virtualvconsole.C: process_buffer: 107
> >     vrender.C: process_buffer: 173
> >     VRender::run 0.3
> >     VRender::run 6
> >     VRender::run 7
> >     VRender::run 8
> >     VRender::run 10
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 261
> >     bcmenu.C: draw_title: 264
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 275
> >     bcmenu.C: draw_title: 278
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 261
> >     bcmenu.C: draw_title: 264
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 275
> >     bcmenu.C: draw_title: 278
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 239
> >     bcmenu.C: draw_title: 242
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 239
> >     bcmenu.C: draw_title: 242
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 239
> >     bcmenu.C: draw_title: 242
> >     bcmenu.C: draw_title: 294
> >     bcmenu.C: draw_title: 235
> >     bcmenu.C: draw_title: 275
> >     bcmenu.C: draw_title: 278
> >     bcmenu.C: draw_title: 294
> >     bcwindowbase.C: get_abs_cursor_x: 2857
> >     bcwindowbase.C: get_abs_cursor_x: 2859
> >     bcwindowbase.C: get_abs_cursor_x: 2869
> >     bcwindowbase.C: get_abs_cursor_x: 2871
> >     bcwindowbase.C: get_abs_cursor_x: 2857
> >     bcwindowbase.C: get_abs_cursor_x: 2859
> >     bcwindowbase.C: get_abs_cursor_x: 2869
> >     bcwindowbase.C: get_abs_cursor_x: 2871
> >     bcwindowbase.C: get_abs_cursor_x: 2857
> >     bcwindowbase.C: get_abs_cursor_x: 2859
> >     bcwindowbase.C: get_abs_cursor_x: 2869
> >     bcwindowbase.C: get_abs_cursor_x: 2871
> >     file.C: open_file: 313
> > signal_entry: lock table size=82
> >     0x9056430 PlaybackEngine::start_lock PlaybackEngine::create_objects *
> >     0x90561a0 CWindowTool::input_lock CWindowTool::run
> >     0x90df0a8 PlaybackEngine::start_lock PlaybackEngine::create_objects *
> >     0x90ff378 TransportQue::output_lock PlaybackEngine::run *
> >     0x9120268 MainIndexes::input_lock MainIndexes::run 1 *
> >     0x91a35e0 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x85044e0 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x8554d50 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x85555d8 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x8552360 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x85567f0 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x9204c30 BC_Repeater::startup_lock BC_Repeater::initialize *
> >     0x9076a08 TransportQue::output_lock PlaybackEngine::run *
> >     0x90ff378 TransportQue::output_lock PlaybackEngine::run
> >     0x9120268 MainIndexes::input_lock MainIndexes::run 1
> >     0xae361440 CommonRender::start_lock CommonRender::start_command *
> >     0x9076a08 TransportQue::output_lock PlaybackEngine::run
> >     0x9067268 LoadPackage::completion_lock LoadServer::process_packages 1 *
> >     0x90671c0 LoadClient::completion_lock LoadServer::process_packages 2 *
> >     0x9067168 LoadClient::input_lock LoadClient::run *
> >     0x9067168 LoadClient::input_lock LoadClient::run
> >     0x91a3588 BC_Repeater::pause_lock BC_Repeater::stop_repeating *
> >     0x91a3588 BC_Repeater::pause_lock BC_Repeater::run
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8503978 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x929f6e0 thread_class::completion PLUGIN_DESTRUCTOR_MACRO *
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x907c040 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x91a4b10 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x908efb8 BC_WindowBase::event_condition BC_WindowBase::get_event
> >     0x8c60640 BC_WindowBase::event_condition BC_WindowBase::get_event
> >     0x907c040 BC_WindowBase::event_condition BC_WindowBase::get_event
> >     0x91a4b10 BC_WindowBase::event_condition BC_WindowBase::get_event
> >     0x8ff12a0 BC_WindowBase::event_condition BC_WindowBase::get_event
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event *
> >     0x9121fd0 BC_WindowBase::event_condition BC_WindowBase::get_event
> > BC_Signals::dump_buffers: buffer table size=0
> > BC_Signals::delete_temps: deleting 0 temp files
> > SigHandler::signal_handler total files=1
> > Closing /home/install/test_render.mov
> > 
> > The generated output file test_render.mov is not completely empty.
> > Some basic header data seems to be written. It's size is about 800 Bytes.
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > >On tor, 2006-04-04 at 08:41 +0200, Toby wrote:
> > >  
> > >
> > >>Andra,
> > >>
> > >>I 'm faced with these crashes for several weeks now.
> > >>I had decided to wait for updated packages at that time,
> > >>because there was no urgent need to work with cinelerra.
> > >>But the last two updates didn't change it. I've tested several
> > >>effects on my own and a bare test account.
> > >>
> > >>Which versions are you using ? athlonxp , pentium4, ... ?
> > >>Does rendering video effects work on your system ?
> > >>And if yes : What video formats did you test ? What's your
> > >>system status and kernel version ?
> > >>I'm only working with  DV (mov oder avi) footage coming from my camcorder
> > >>grabbed with dvgrab or kino - not with cinelerra.
> > >>Do you think it's worth converting it to a different format for testing
> > >>purpose ?
> > >>
> > >>F.Y.I. ... I'm using Debian unstable + Christan Marillats video packages.
> > >>My last distupgrade was about a week ago.
> > >>Everything should be pretty recent.
> > >>
> > >>Toby
> > >>    
> > >>
> > >
> > >
> > >
> > >Hmm i don't know what crushes are caused by...  i've today fixed another
> > >two bugs, but that should not be it.
> > >
> > >what exactly are you working on.. instead of using optimized build, try
> > >to use nonoptimized one 
> > >
> > >
> > >yes, rendering video effects does work on my system, that's why i am
> > >asking what you ...
> > >
> > >do you have reproducable crushes - that always happen after certain set
> > >of actions ... ?
> > >
> > >čao
> > >andraž
> > >
> > >
> > >_______________________________________________
> > >Cinelerra mailing list
> > >[email protected]
> > >https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
> > >
> > >
> > >  
> > >
> > 
> > _______________________________________________
> > Cinelerra mailing list
> > [email protected]
> > https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
> 
> 
> _______________________________________________
> Cinelerra mailing list
> [email protected]
> https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
--- hvirtual-cvs/cinelerra/vmodule.C	2006-02-12 21:24:57.000000000 +0100
+++ hvirtual-2/cinelerra/vmodule.C	2006-04-07 01:30:35.000000000 +0200
@@ -41,8 +41,11 @@
 	overlay_temp = 0;
 	input_temp = 0;
 	transition_temp = 0;
-	masker = new MaskEngine(renderengine->preferences->processors);
-
+	if (renderengine)
+		masker = new MaskEngine(renderengine->preferences->processors);
+	else
+		masker = new MaskEngine(plugin_array->mwindow->preferences->processors);
+	
 }
 
 VModule::~VModule()
@@ -452,8 +455,13 @@
 SET_TRACE
 	}
 	
+	int64_t mask_position;
+	if (renderengine)
+		mask_position = renderengine->vrender->current_position;
+	else 
+		mask_position = start_position;
 	masker->do_mask(output, 
-		renderengine->vrender->current_position,
+		mask_position,
 		edl_rate,
 		edl_rate,
 		(MaskAutos*)track->automation->autos[AUTOMATION_MASK], 

Reply via email to