> And yeah, I don't know what I was thinking... when I wrote that....
> The lines should read:
> as = (s - sat - min_s) / (min_s * 2);
> av = (s - min_v ) / (min_v * 2) ;
> avm = 1 / 2 + (v - max_v_out ) / (max_v_out *2);
>
> And here's the patch (I modified another line for consistency)
>
> I did a quick test and it looks obviously better.
> Let me know how that works out for you !
By the way, your equations for "av" and "avm" still use "s".
Finally, you're still using 1/2 everywhere. At least in gcc, this
evaluates to 0 which works.
Actually using 0.5 breaks it.
In 7 years of designing chromakey effects, hue keying has always
produced the coarsest results.
The reason is hue only has 1/3 the information of the color cube.
Chromakeying with 8 bit consumer
cameras doesn't work. You can spend a lot of time desigining chromakey
algorithms and learn about
software engineering that way, but you're not going to get very far.
You need really good lighting, perfectly consistent mattes, and a 10 bit
camera to get TV
weather forecast quality. To get cinematic quality, you need a lot of
manual artifact removal
in Cinepaint. At least you only have to airbrush 25fps. If you were
American you'd have to
airbrush 30fps.
_______________________________________________
Cinelerra mailing list
[email protected]
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
