On 3/13/07, Kevin Brosius <[EMAIL PROTECTED]> wrote:
You don't mention if you tested this patch with the in-tree version of
ffmpeg? I suspect anyone who takes a look at the patch will need to
test that case, unless you have already. Please let us know if you
considered this case.
I'm resending the patch as an attachment. I'll also put it here:
--- fileyuv.C.original 2007-03-10 17:53:56.000000000 -0600
+++ fileyuv.C 2007-03-10 17:54:31.000000000 -0600
@@ -415,8 +415,8 @@ int YUVConfigVideo::create_objects()
x += 180;
add_subwindow(ffmpeg = new PipePreset(x, y, "ffmpeg", pipe_textbox,
pipe_checkbox));
- ffmpeg->add_item(new BC_MenuItem("(DVD) | ffmpeg -f yuv4mpegpipe -i
- -y -target dvd -ilme -ildct -hq -f mpeg2video %"));
- ffmpeg->add_item(new BC_MenuItem("(VCD) | ffmpeg -f yuv4mpegpipe -i
- -y -target vcd -hq -f mpeg2video %"));
+ ffmpeg->add_item(new BC_MenuItem("(DVD) | ffmpeg -f yuv4mpegpipe -i
- -y -target dvd -ilme -ildct -f mpeg2video %"));
+ ffmpeg->add_item(new BC_MenuItem("(VCD) | ffmpeg -f yuv4mpegpipe -i
- -y -target vcd -f mpeg2video %"));
add_subwindow(new BC_OKButton(this));
add_subwindow(new BC_CancelButton(this));
I'm not sure how to test this against the in tree version of ffmpeg. The
patch only affects the presets on the yuv4mpeg drop down. I did not think
this change would affect any other ffmpeg calls.
Hannes was concerned about older versions of ffmpeg. The way the preset is
now, anyone using a recent version of ffmpeg has to change the preset. The
change shifts the responsibility to someone using an older version of ffmpeg
to add the -hq option if that is what they want.
Thank you both for your replies.
Thanks for your
--- fileyuv.C.original 2007-03-10 17:53:56.000000000 -0600
+++ fileyuv.C 2007-03-10 17:54:31.000000000 -0600
@@ -415,8 +415,8 @@ int YUVConfigVideo::create_objects()
x += 180;
add_subwindow(ffmpeg = new PipePreset(x, y, "ffmpeg", pipe_textbox, pipe_checkbox));
- ffmpeg->add_item(new BC_MenuItem("(DVD) | ffmpeg -f yuv4mpegpipe -i - -y -target dvd -ilme -ildct -hq -f mpeg2video %"));
- ffmpeg->add_item(new BC_MenuItem("(VCD) | ffmpeg -f yuv4mpegpipe -i - -y -target vcd -hq -f mpeg2video %"));
+ ffmpeg->add_item(new BC_MenuItem("(DVD) | ffmpeg -f yuv4mpegpipe -i - -y -target dvd -ilme -ildct -f mpeg2video %"));
+ ffmpeg->add_item(new BC_MenuItem("(VCD) | ffmpeg -f yuv4mpegpipe -i - -y -target vcd -f mpeg2video %"));
add_subwindow(new BC_OKButton(this));
add_subwindow(new BC_CancelButton(this));
