fixed and applied in r1056.

rafael diniz

Em Wednesday 02 April 2008, Johannes Sixt escreveu:
> On Wednesday 02 April 2008 17:01, rafael2k wrote:
> > +     if test x"$enable_ffmpeg_swscale" == xyes; then
>
> This should be a single =. == is a bashism.
>
> > Index: cinelerra/ffmpeg.h
> > ===================================================================
> > --- cinelerra/ffmpeg.h  (revision 1055)
> > +++ cinelerra/ffmpeg.h  (working copy)
> > @@ -3,8 +3,14 @@
> >
> >  extern "C" {
> >  #include <avcodec.h>
> > -};
> > +}
> >
> > +#ifdef HAVE_SWSCALER
> > +extern "C" {
> > +#include <swscale.h>
> > +}
> > +#endif
>
> I doubt that it is necessary to have this in ffmpeg.h. Can you move this
> #include into ffmpeg.C, if possible?
>
> Otherwise the patch looks fine.
>
> -- Hannes


-- 
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
Ciência da Computação @  Unicamp
Rádio Muda, radiolivre.org, TV Piolho, tvlivre.org, www.midiaindependente.org
Chave PGP: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x2FF86098
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to