On Mittwoch, 9. Juli 2008, percy tiglao wrote: > I sent in a patch here on the mailing list a few days ago on the > Spectrometer plugin. Between then and now I found another bug in the > old spectrometer code, so I fixed it up with this patch.
Thanks a lot, this all sounds very great. I like your detailed description of what you have changed. > 4. The SpectrogramFFT class was redone almost completely to take > advantage of the "fftw" library. As noted above, buffering was added > between read_samples for efficiency. SpectrogramFFT no longer inherits > from CrossfadeFFT, and adhears closer to the RAII paradigm now. (I > didn't bother to make it "clean" by removing copy constructors and > assignment operators... but none of the other classes in the codebase > seem to follow RAII anyway) It would have been great if this transition were a separate patch. (Rationale: If we later find out something's foul and an emergency fix is needed, it is easier to just revert this part.) I'll certainly look into the patch, but I'm a bit overloaded currently. -- Hannes _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
