Frans, Just try it by yourself. If more compiling errors come up, we can fix then. I compiled cinelerra w/ both internal and external ffmpeg (from today svn), and it's working ok here (at least for the simple test I did).
Bye, Rafael Diniz Em Saturday 27 September 2008, Frans de Boer escreveu: > On Sat, 2008-09-27 at 15:05 -0300, rafael2k wrote: > > Hello KH, > > OK, it's nice to ifdef things. > > I thing it's ok to use > > #if LIBAVCODEC_VERSION_INT < ((52<<16)+(0<<8)+0) > > for the code before the patch. > > > > > > bye, > > rafael diniz > > > > Em Saturday 27 September 2008, KH KH escreveu: > > > 2008/9/27 rafael2k <[EMAIL PROTECTED]>: > > > > Ow, it was quite easy to fix. > > > > Can anyone review the patch to fix cinelerra w/ the newer ffmpeg API? > > > > I think the fix is correct, as I got it looking at the ffmpeg svn > > > > diff. > > > > > > What if this fix is present while an older ffmpeg api is used ? > > > > > > In the vlc case (for a sample), the ffmpeg API changes are > > > conditionalized... This gives something like this: > > > --------------- > > > #if LIBAVCODEC_VERSION_INT < ((52<<16)+(0<<8)+0) > > > p_sys->p_context->bits_per_sample = > > > p_dec->fmt_in.audio.i_bitspersample; #else > > > p_sys->p_context->bits_per_coded_sample = > > > p_dec->fmt_in.audio.i_bitspersample; > > > #endif > > > --------------- > > > > > > Nicolas (kwizart) > > I just wonder, if that is all that is changed? The discussion on the > FFmpeg-devel mailing list (albeit sometime quite strong) resulted in the > announcement that r15621 was the last 51 version. Now it seems that > there is one (!) change in structure member only?!! > > What about 'error_resilience' being renamed to 'error_recognition'? > Note that libquicktime has been affected too. -- +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+- Ciência da Computação @ Unicamp Rádio Muda, radiolivre.org, TV Piolho, tvlivre.org, www.midiaindependente.org Chave PGP: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x2FF86098 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
signature.asc
Description: This is a digitally signed message part.
