-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 oh, forgot cinelerra ML :-/
- -------- Original Message -------- Subject: Re: Cinelerra CinCV merge request / Cin2.1.5CV Date: Tue, 26 Oct 2010 22:39:57 +0200 From: Simeon Völkel <simeon.voel...@...> To: Johannes Sixt <j...@...> CC: Monty Montgomery <xiphm...@...> On 10/26/10 22:12, Johannes Sixt wrote: > On Sonntag, 24. Oktober 2010, Simeon Völkel wrote: >> today Monty and I worked out which of his changes are independent from his >> ffmpeg loader project and fix bugs of CinCV. >> >> I've merged these commits over into my repo[1] and would like to ask you to >> pull these changes (everything from october, starting with [2], except for >> the one commit[3] which states that it is not for CinCV) over into the >> official CinCV repo. > > I didn't take these: > > - f4b7d222 apply gentoo libavutil50 patch > This substitutes RGBA* by RGB color codes. How can this be good? > Please explain. I just took over the patch which is applied by gentoo when compiling cin using emerge, as otherwise it does not compile here. If i've got some time tomorrow, I'll have a look at what actually changed in libavutil and whether RGBA color codes are still supported. > > - b789d4ff fix background rendering crash on >=jpeg-7 > This doesn't compile here. It needs version checks around uses of > do_fancy_upsampling. I'll add them. Didn't recognize that as background rendering was broken for almost one year on my boxes, however not on others, obviously due to jpeg-7/8. Haven't tested it on a not-jpeg-7/8 installation. > > - 8aa33e3e Rwrite the latency timing/calculation for the OSS backend > There is parctically no explanation why the change is good and why > a new mutex is needed. It looks dangerous. How extensively has the > code been excercised? Why is a change needed at all? I am not aware > of people complaining that the OSS driver does not work. But I > might be missing something. > > - e0569663 Actually check for error return codes in OSS > This does not adhere to the coding standard that is used in surrounding > code. Fixing that would take too much of my time. Remember that it is > good tone to copy the coding style that you find rather than to force > your own style onto existing code. This includes white-space style. > (IOW, please use tabs, not 8 spaces.) > Monty will explain the need and purpose of the two OSS changes in more detail. > - 48e292ec Add ArchLinux x264-quicktime build patch > This does in no way explain what the patch solves. I cannot judge why > the change would be good. > This was taken over from Monty's repo, however it seems to be applied as well by gentoo without explanation. I'll try to figure out where this patch comes from. > - 64e8022f Eliminate the YUV file loader's wont > Before I merge this change, I'd like to know why the patch solves a > problem (and what the problem exactly is). "It happens more often > than you think" is a bit too much hand-waving. Can I easily reproduce > the bug? (Oh, and the commant about coding style applies, too.) Monty will explain in detail; It seems as if YUV frames can't differ in size, thus creating an index is wasting resources. > > - e40c03ad remove hardcoded cinelerra/versioninfo.h and add README.Cin2.1SV > What is this about? I'm sorry, didn't recognize that commit when writing the mail, that commit does not apply to CinCV, just to my repo (CinSV). It was not intended to be merged into CinCV :D > > I pushed out my state to > > git://git.cinelerra.org/j6t/cinelerra.git sv/gentoo-fixes > Thanks! > This state doesn't work for me (it crashes on the first playback of DV), > hence, I didn't push it to master right away. I'll investigate. Ok, i haven't used DV yet in my latest version, but edited and rendered already a small test project in HDV. Maybe you could paste a backtrace to bugs.cinelerra.org or so. With best regards, Simeon -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkzHPocACgkQph/voQkhF7yzagCgyBaGTeHyqpF9W4jno7nbIzxY tpsAoKwBAYOvzydXKbz2GwxSFfyDMKjX =PwyK -----END PGP SIGNATURE----- _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
