>> People are, in general, used to sync always being broken. :-) > > OK. > > Speaking of sync: With the patches applied, I get acceptable playback only > when I "Disable hardware synchronization".
Ah, that part of the patch got cherrypicked too, OK. I renamed the option in my own tree so that it says what it actually does. > Otherwise, although audio output > is continuous, video is jerky at the beginning, and then catches up with the > audio. This happens at every playback change (forward, reverse, half-speed, > normal-speed, double-speed). With OSS? Well, that's obviously not good. FTR, this is the behavior I got in the old source before patches. Are you on a Linux kernel? If so, which one? If not... which one? :-) The problem with the old code was not that it had any logic faults that I saw, but that the ioctl set it was calling simply didn't work according to spec or any other reasonable behavior I could discern (and in my memory never has, at least on Linux). I switched to the ioctl set that does work, at least on Linux, and that I'd previously always used in my own code. Or maybe it's some other bug entirely. If it doesn't work, it obviously needs to be fixed. Shall I re-add the debugging output to see what's going on? > Actually, it is about both. > > What if I have to fix your code? My formating is different from yours again. > It's going to make a an unacceptable mess. It doesn't really ever seem to be a problem elsewhere. The norm, at least in projects I work with, is not to enforce a rigid style. > Please find out how to set the style for Emacs. It's certainly possible. I don't mean to be impolite, but no, I don't plan to do this. If this is unacceptable, I will not press the point, but I will also use the style I prefer in my own tree. If you have a prepackaged mode you can point me to that I can turn on and off easily per-buffer, I'll use it (eg, what the Linux kernel offers). Strict reformatting can also be done as a commit hook. > Thanks, it's appreciated. One *important* piece of information is that this is > about YUV4MPEG2 loader, not about any sort of YUV-like frames. This restricts > the scope of the patch quite a lot and makes it less critical. Yes, correct. The code internally simply calls this loader 'yuv' and so I called it the same. Monty _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
