On Sat, 03 Sep 2011 13:18:20 -0700, Einar Rünkaru <[email protected]> wrote:
This requires a precise calculation in ReframeRT to stretch the
video sources to resync them. 4 digits are not enough.
Therefore I propose the following patch.
Why minor fix in one plugin requires change in gui framework?
During construction, textbox is initialized with the default value passed
by the TumbleTextBox constructor.
I could simply override that by doing this:
$ git diff
diff --git a/plugins/reframert/reframert.C b/plugins/reframert/reframert.C
index dd5075a..009b362 100644
--- a/plugins/reframert/reframert.C
+++ b/plugins/reframert/reframert.C
@@ -227,8 +227,10 @@ void ReframeRTWindow::create_objects()
this,
x,
y);
+ scale->set_precision(8);
scale->create_objects();
scale->set_increment(0.1);
+ scale->update((float)plugin->config.scale);
y += 30;
add_subwindow(stretch = new ReframeRTStretch(plugin,
this,
... but that would mean the textbox value being initialized uselessly
twice! Once in create_objects() and once again in the ReframeRT
initalization override by me.
I don't know the code enough to go deeper and find out the reasons for
having "create_objects" out of the constructor.
Fair enough, I don't know how this affects other parts of the code, but I
don't think it should because the patch modifies object creation and just
updates the values with the "default value" passed by the plugin request,
and hey, if the plugin is requesting precision != 4 before object
creation, it should go initialized like that, right?
Best regards.
--
Octavio.
Twitter: @alvarezp2000 -- Identi.ca: @alvarezp
_______________________________________________
Cinelerra mailing list
[email protected]
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
