On Mon, May 23, 2005 at 04:09:15PM -0700, Matthew Helsley wrote:
> 
> 
> On Mon, 2005-05-23 at 15:39 -0700, Chandra Seetharaman wrote:
> > On Sat, May 21, 2005 at 02:49:47AM -0700, Matthew Helsley wrote:
> > > Index: linux-2.6.12-rc3/kernel/ckrm/ckrm_tc.c
> > > ===================================================================
> > > --- linux-2.6.12-rc3.orig/kernel/ckrm/ckrm_tc.c   2005-05-13 
> > > 20:01:48.846410256 -0700
> > > +++ linux-2.6.12-rc3/kernel/ckrm/ckrm_tc.c        2005-05-13 
> > > 20:05:52.533364208 -0700
> > > @@ -33,10 +33,12 @@
> > >  #include <linux/module.h>
> > >  #include <linux/ckrm_rc.h>
> > >  
> > >  #include <linux/ckrm_tc.h>
> > >  
> > > +#define TASK_EXIT_CLASS ((void*)-1)
> > > +
> > 
> > Matt,
> > can you move this to ckrm_rc.h and use it in the definition of
> > ckrm_get_res_class() ( I think you covered all the other usages with this 
> > patch).
> > 
> > thanks
> > 
> > chandra
> 
> I like your point, but I'm not sure it belongs there. Do we really want
> to stuff Taskclass classtype-specific definitions in there? Wouldn't
> ckrm_tc.h be more appropriate?

valid point. since ckrm_get_res_class also is taskclass specific, you can
move that as well to ckrm_tc.h, and may be rename it to
ckrm_get_taskclass()...
> 
> Cheers,
>       -Matt
> 
> 
> 

-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [EMAIL PROTECTED]   |      .......you may get it.
----------------------------------------------------------------------


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to