From: Shailabh Nagar <[EMAIL PROTECTED]>
Subject: Re: [ckrm-tech] [PATCH 2/5] CKRM I/O controller (2.6.12): Cloning CFQ
Date: Fri, 15 Jul 2005 13:22:43 -0400
> > I couln't find any code initializing the pic member for newly
> > allocated io_context.
> >
> > It should be initialized in get_io_context(), shouldn't it?
>
> Yes again. And request for a patch again !
>
> Thanks,
> Shailabh
Here you are.
Initialize io_context->pic for newly created io_context, otherwise
ps_get_io_context() may access illegal address.
Signed-Off-By: Maeda Naoaki <[EMAIL PROTECTED]>
---
linux-2.6.12-ckrm-maeda/drivers/block/ll_rw_blk.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/block/ll_rw_blk.c~init_pic_in_io_context
drivers/block/ll_rw_blk.c
--- linux-2.6.12-ckrm/drivers/block/ll_rw_blk.c~init_pic_in_io_context
2005-07-15 17:19:26.000000000 +0900
+++ linux-2.6.12-ckrm-maeda/drivers/block/ll_rw_blk.c 2005-07-15
17:19:58.000000000 +0900
@@ -3354,6 +3354,7 @@ struct io_context *get_io_context(int gf
ret->nr_batch_requests = 0; /* because this is 0 */
ret->aic = NULL;
ret->cic = NULL;
+ ret->pic = NULL;
spin_lock_init(&ret->lock);
local_irq_save(flags);
_
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
