On Fri, 2005-09-30 at 17:16 +0900, MAEDA Naoaki wrote:
> Hi Chandra,
>
> Since Kurosawa-san's cpu controller only supports guarantee
> and doesn't support limit, I set CKRM_SHARE_DONTCARE to
> the my_limit and max_limit in order not to take account of them.
>
> However, when I try to set guarantee, the ckrm_set_shares() failes
> at the following last if statement.
>
> + /* make sure guarantee is lesser than limit */
> + if (new->my_limit == CKRM_SHARE_DONTCARE)
> + /* do nothing */;
> + else if (new->my_limit == CKRM_SHARE_UNCHANGED) {
> + if (new->my_guarantee == CKRM_SHARE_DONTCARE)
> + /* do nothing */;
> + else if (new->my_guarantee == CKRM_SHARE_UNCHANGED)
> + /*
> + * do nothing; earlier setting would have
> + * taken care of it
> + */;
> + else if (new->my_guarantee > cur->my_limit)
> + goto set_share_err;
>
> I cannot set any positive value to the new->my_guarantee,
> because the cur->my_limit is CKRM_SHARE_DONTCARE, which is (-2).
>
> I think we should add one more "else if" before the last one
> to check if the cur->my_limit is CKRM_SHARE_DONTCARE and do nothing.
You are right. It needs to be fixed (both in e19 and f-series).
>
> Or, am I mis-understanding CKRM_SHARE_DONTCARE usage?
>
> Thanks,
> MAEDA Naoaki
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Power Architecture Resource Center: Free content, downloads, discussions,
> and more. http://solutions.newsforge.com/ibmarch.tmpl
> _______________________________________________
> ckrm-tech mailing list
> https://lists.sourceforge.net/lists/listinfo/ckrm-tech
>
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- [EMAIL PROTECTED] | .......you may get it.
----------------------------------------------------------------------
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
