Sorry folks, another resend. While responding, pls add all the ids
except ckrm-tech, lse-tech and elsa-devel.
(the standard IBM smtp server seems to be getting tagged by Spamcop so
some messages get blocked)
--Shailabh
-------- Original Message --------
Subject: Re: [ckrm-tech] Re: [Patch 6/6] Delay accounting: Connector
interface
Date: Wed, 04 Jan 2006 19:01:46 -0500
From: Shailabh Nagar <[EMAIL PROTECTED]>
To: Matt Helsley <[EMAIL PROTECTED]>
CC: Jay Lan <[EMAIL PROTECTED]>, Andrew Morton <[EMAIL PROTECTED]>,
linux-kernel <linux-kernel@vger.kernel.org>, elsa-devel
<[EMAIL PROTECTED]>, LSE
<[EMAIL PROTECTED]>, CKRM-Tech
<ckrm-tech@lists.sourceforge.net>, Paul Jackson <[EMAIL PROTECTED]>, Erik
Jacobson <[EMAIL PROTECTED]>, Jack Steiner <[EMAIL PROTECTED]>, John
Hesterberg <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]> <[EMAIL PROTECTED]>
<[EMAIL PROTECTED]>
Matt Helsley wrote:
On Wed, 2006-01-04 at 11:04 -0800, Jay Lan wrote:
Shailabh Nagar wrote:
<snip>
Index: linux-2.6.15-rc7/kernel/exit.c
===================================================================
--- linux-2.6.15-rc7.orig/kernel/exit.c
+++ linux-2.6.15-rc7/kernel/exit.c
@@ -29,6 +29,7 @@
#include <linux/syscalls.h>
#include <linux/signal.h>
#include <linux/cn_proc.h>
+#include <linux/cn_stats.h>
#include <asm/uaccess.h>
#include <asm/unistd.h>
@@ -865,6 +866,7 @@ fastcall NORET_TYPE void do_exit(long co
tsk->exit_code = code;
proc_exit_connector(tsk);
+ cnstats_exit_connector(tsk);
We need to move both proc_exit_connector(tsk) and
cnstats_exit_connector(tsk) up to before exit_mm(tsk) statement.
There are task statistics collected in task->mm and those stats
will be lost after exit_mm(tsk).
Thanks,
- jay
exit_notify(tsk);
#ifdef CONFIG_NUMA
mpol_free(tsk->mempolicy);
-
Good point. The assignment of the task exit code will also have to move
up before exit_mm(tsk) because the process event connector exit function
retrieves the exit code from the task struct.
Why does proc_exit_connector need to move ? It only uses
task->{pid,tgid,exit_code,exit_signal}, none of which
should be affected by exit_mm(), right ?
-- Shailabh
Moving these may also affect the job/pagg/task_notify/cpuset exit
notification if we're eventually going to remove *direct* calls to these
from kernel/exit.c.
Cheers,
-Matt Helsley
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
