On Wed, 2006-08-16 at 19:39 +0400, Kirill Korotaev wrote: <snip>
> +/* > + * The setbeanlimit syscall > + */ > +asmlinkage long sys_setublimit(uid_t uid, unsigned long resource, > + unsigned long *limits) > +{ > + int error; > + unsigned long flags; > + struct user_beancounter *ub; > + unsigned long new_limits[2]; > + > + error = -EPERM; > + if(!capable(CAP_SYS_RESOURCE)) > + goto out; > + > + error = -EINVAL; > + if (resource >= UB_RESOURCES) > + goto out; > + > + error = -EFAULT; > + if (copy_from_user(&new_limits, limits, sizeof(new_limits))) > + goto out; > + > + error = -EINVAL; > + if (new_limits[0] > UB_MAXVALUE || new_limits[1] > UB_MAXVALUE) > + goto out; > + > + error = -ENOENT; > + ub = beancounter_findcreate(uid, NULL, 0); > + if (ub == NULL) > + goto out; > + > + spin_lock_irqsave(&ub->ub_lock, flags); > + ub->ub_parms[resource].barrier = new_limits[0]; > + ub->ub_parms[resource].limit = new_limits[1]; >From my understanding it appear that barrier <= limit. But, the check is missing here. > + spin_unlock_irqrestore(&ub->ub_lock, flags); > + > + put_beancounter(ub); > + error = 0; > +out: > + return error; > +} > +#endif > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > ckrm-tech mailing list > https://lists.sourceforge.net/lists/listinfo/ckrm-tech -- ---------------------------------------------------------------------- Chandra Seetharaman | Be careful what you choose.... - [EMAIL PROTECTED] | .......you may get it. ---------------------------------------------------------------------- ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech