Hi,

On Tue, 29 Aug 2006, Kirill Korotaev wrote:

> --- ./kernel/user.c.dlirq     2006-07-10 12:39:20.000000000 +0400
> +++ ./kernel/user.c   2006-08-28 11:08:56.000000000 +0400
> @@ -108,15 +108,12 @@ void free_uid(struct user_struct *up)
>       if (!up)
>               return;
> 
> -     local_irq_save(flags);
> -     if (atomic_dec_and_lock(&up->__count, &uidhash_lock)) {
> +     if (atomic_dec_and_lock_irqsave(&up->__count, &uidhash_lock, flags)) {
>               uid_hash_remove(up);
>               spin_unlock_irqrestore(&uidhash_lock, flags);
>               key_put(up->uid_keyring);
>               key_put(up->session_keyring);
>               kmem_cache_free(uid_cachep, up);
> -     } else {
> -             local_irq_restore(flags);
>       }
> }

Why does this need protection against interrupts?

bye, Roman

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to