Pavel Emelianov wrote: >> That's like disabling memory over-commit in the regular kernel. > > Nope. We limit only unreclaimable mappings. Allowing user > to break limits breaks the sense of limit. > > Or you do not agree that allowing unlimited unreclaimable > mappings doesn't alow you the way to cut groups gracefully? >
A quick code review showed that most of the accounting is the same. I see that most of the mmap accounting code, it seems to do the equivalent of security_vm_enough_memory() when VM_ACCOUNT is set. May be we could merge the accounting code to handle even containers. I looked at do_mmap_pgoff acct_stack_growth __do_brk ( do_mremap > [snip] > >> Please see the patching of Rohit's memory controller for user >> level patching. It seems much simpler. > > Could you send me an URL where to get the patch from, please. > Or the patch itself directly to me. Thank you. Please see http://lkml.org/lkml/2006/9/19/283 > > [snip] > >> I would prefer a different set >> >> 1 & 2, for now we could use any interface and then start developing the >> controller. As we develop the new controller, we are likely to find the >> need to add/enhance the interface, so freezing in on 1 & 2 might not be >> a good idea. > > Paul Menage won't agree. He believes that interface must come first. > I also remind you that the latest beancounter patch provides all the > stuff we're discussing. It may move tasks, limit all three resources > discussed, reclaim memory and so on. And configfs interface could be > attached easily. > I think the interface should depend on the controllers and not the other way around. I fear that the infrastructure discussion might hold us back and no fruitful work will happen on the controllers. Once we add and agree on the controller, we can then look at the interface requirements (like persistence if kernel memory is being tracked, etc). What do you think? >> I would put 4, 5 and 6 ahead of 3, based on the changes I see in Rohit's >> memory controller. >> >> Then take up the rest. > > I'll review Rohit's patches and comment. ok -- Thanks, Balbir Singh, Linux Technology Center, IBM Software Labs ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ ckrm-tech mailing list https://lists.sourceforge.net/lists/listinfo/ckrm-tech
