Hello!
Appended are a few very minor patches:
gl/rasterization.lisp:
- in gl:tex-parameter's :texture-border-color use "elt" rather than
"aref", to be consistent with other calls in the file
- in gl:fog allow :fog-color -- I hope this is done in a manner
consistent with cl-opengl style?
glu/glu.lisp:
- change names of some gluPerspective parameters to match their standard names
Thanks for the very useful cl-opengl code! I hope these are worth applying!
Best,
Dan
diff -rN -u old-cl-opengl/gl/rasterization.lisp new-cl-opengl/gl/rasterization
.lisp
--- old-cl-opengl/gl/rasterization.lisp 2008-06-13 15:05:20.000000000 -0400
+++ new-cl-opengl/gl/rasterization.lisp 2008-06-13 15:05:20.000000000 -0400
@@ -265,7 +265,7 @@
(:texture-border-color
(with-foreign-object (array '%gl:float 4)
(dotimes (i 4)
- (setf (mem-aref array '%gl:float i) (float (aref param i))))
+ (setf (mem-aref array '%gl:float i) (float (elt param i))))
(%gl:tex-parameter-fv target pname array)))
((:texture-priority :texture-min-lod :texture-max-lod)
(%gl:tex-parameter-f target pname (float param)))
@@ -376,6 +376,11 @@
(defun fog (pname param)
(ecase pname
+ (:fog-color
+ (with-foreign-object (c '%gl:float 4)
+ (dotimes (i 4)
+ (setf (mem-aref c '%gl:float i) (float (elt param i))))
+ (%gl:fog-fv pname c)))
(:fog-mode
(%gl:fog-i pname (foreign-enum-value '%gl:enum param)))
(:fog-coord-src
diff -rN -u old-cl-opengl/glu/glu.lisp new-cl-opengl/glu/glu.lisp
--- old-cl-opengl/glu/glu.lisp 2008-06-13 15:05:20.000000000 -0400
+++ new-cl-opengl/glu/glu.lisp 2008-06-13 15:05:20.000000000 -0400
@@ -123,9 +123,9 @@
(defcfun ("gluPerspective" perspective) :void
(fov-y %gl:double)
- (right %gl:double)
- (bottom %gl:double)
- (top %gl:double))
+ (aspect %gl:double)
+ (zNear %gl:double)
+ (zFar %gl:double))
(defcfun ("gluLookAt" look-at) :void
(eye-x %gl:double)
_______________________________________________
cl-opengl-devel mailing list
[email protected]
http://common-lisp.net/cgi-bin/mailman/listinfo/cl-opengl-devel
