While clearing compilation warnings in CLAM, I detected what looks like a bug in the SpectralPeakArray addition/merge: we are taking values for the target phase array from the magnitude array of the origin. The warning complained about the cached reference to the operand phase arrays being unused.
By commenting out the operator, the only code that complains are the SMSHarmonizer and the SegmentSMSHarmonizer so I guess that's the impact of the bug or an eventual fix. No unit test covers the addition and no functional test covers the SMSHarmonizer. Xavi, my fix proposal is to take the phase as is from the merged arrays but I dont know if this dumb phase merging has any impact on synthesis. David. _______________________________________________ clam-devel mailing list clam-devel@lists.clam-project.org http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org
