On Tue, 30 May 2006 13:23:59 +0200
Peter Vollmer <[EMAIL PROTECTED]> wrote:

> Hi,
> 
> I prepared a patch for database loading from the cvd archives without
> unpacking the database to tmp space first. It should fit to current CVS.
> Right now its only implemented for clamd. To test, please add the following
> clamd.conf option:
> 
> LoadPackedDatabase yes
> 
> Please test, any suggestions are welcome.

Hi Peter,

this patch is not acceptable to me because it doubles most of the current
code in readdb.c making it 13 kilobytes bigger and harder to maintain. Instead
of doing that, you should make the cli_load*() routines work on buffers and
only add new functions for direct reading of .tar.gz. Also, please follow the
general rules for patches defined by NJH in clamav-milter/INSTALL (5.1
Patches).

-- 
   oo    .....         Tomasz Kojm <[EMAIL PROTECTED]>
  (\/)\.........         http://www.ClamAV.net/gpg/tkojm.gpg
     \..........._         0DCA5A08407D5288279DB43454822DC8985A444B
       //\   /\              Wed Jun  7 11:29:25 CEST 2006

Attachment: signature.asc
Description: PGP signature

_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html

Reply via email to