I agree.  We already have some logic in freshclam to convert bytes to human 
readable B / KiB / MiB / GiB format.  It should be pretty much a copypaste 
effort to improve the data scanned/read output. 

-Micah

On 11/2/20, 9:47 AM, "clamav-users on behalf of G.W. Haywood via clamav-users" 
<[email protected] on behalf of 
[email protected]> wrote:

    Hi there,

    On Mon, 2 Nov 2020, Paul Kosinski via clamav-users wrote:

    > ... I still think it is a bad message that should be fixed.

    +1

    If you want to try a very quick and dirty tweak to get more precise
    numbers, change the value of

    1) CL_COUNT_PRECISION in .../libclamav/clamav.h from 4096 to 1

    2) replace '1024' with '1' in four places in clamscan/clamscan.c

    3) change 'MB' to 'Bytes' in two places in clamscan/clamscan.c and

    4) rebuild.

    8<----------------------------------------------------------------------
    ~/clamav-0.103.0-rc2: $ grep -C3 -r CL_COUNT_PRECISION clamscan libclamav | 
...
    ...
    ...
    clamscan/clamscan.c:        mb = info.blocks * (CL_COUNT_PRECISION / 1024) 
/ 1024.0;
    clamscan/clamscan.c:        logg("Data scanned: %2.2lf MB\n", mb);
    clamscan/clamscan.c:        rmb = info.rblocks * (CL_COUNT_PRECISION / 
1024) / 1024.0;
    clamscan/clamscan.c:        logg("Data read: %2.2lf MB (ratio %.2f:1)\n", 
rmb, info.rblocks ? (double)info.blocks / (double)info.rblocks : 0);
    ...
    ...
    libclamav/clamav.h:#define CL_COUNT_PRECISION 4096
    ...
    ...
    8<----------------------------------------------------------------------

    This is untested, YMMV.  Obviously, if you're skilled in the art, this
    can be done better.  Note that 'MB' should in any case be 'MiB' as the
    values printed are the counts divided by 2^20 and not by 10^6.

    -- 

    73,
    Ged.

    _______________________________________________

    clamav-users mailing list
    [email protected]
    https://lists.clamav.net/mailman/listinfo/clamav-users


    Help us build a comprehensive ClamAV guide:
    https://github.com/vrtadmin/clamav-faq

    http://www.clamav.net/contact.html#ml


_______________________________________________

clamav-users mailing list
[email protected]
https://lists.clamav.net/mailman/listinfo/clamav-users


Help us build a comprehensive ClamAV guide:
https://github.com/vrtadmin/clamav-faq

http://www.clamav.net/contact.html#ml

Reply via email to