Tom Tromey wrote:
>
> Ian> The attatched diff replaces that approach with a private instance
> Ian> of java.util.LinkedList.
>
> I don't have an opinion on this patch. I doubt I understand the
> tradeoffs involved (I know little about AWT).
Much the same as with OOP vs. procedural programming in general, I
imagine. On the upside, by delegate the process of accessing and
modifying the linked list to a class specifically designed for that
purpose you reduce the influence of human error and automatically
benefit from any improvements made to the LinkedList class. On the
downside, you do incur the overhead of object instantiation and method
invocation.
>
> But, could you send context diffs or unidiffs and a ChangeLog entry in
> the future? That makes the diff easier to read.
Not a problem.
Perhaps this should be added to the Classpath FAQ (assuming such a
beastly exists...)
>
> BTW do you have paperwork filed with the FSF? (I don't know. If you
> do, I'll be happy to check this patch in for you.)
No I haven't. Who should I talk to to get the ball rolling on this?
Ian
