Whoops, accidentily hit "send" before writing anything.
Anyway, it's fixed, patch attached.
/Sven
On Sun, 2005-04-17 at 12:48 +0200, Jeroen Frijters wrote:
> Sven de Marothy wrote:
> > The final version has been comitted. It differs somewhat, so
> > here's that patch again.
> >
> > 2005-04-15 Sven de Marothy <[EMAIL PROTECTED]>
> >
> > * gnu/java/nio/charset/EncodingHelper.java: Added method
> > * java/io/InputStreamReader.java,
> > * java/io/OutputStreamWriter.java,
> > * java/lang/String.java: Move to NIO charsets.
> > * java/io/PrintStream.java: Inline conversion using String.
>
> Sven you accidentally made the value, count and offset fields in String
> public.
>
> Regards,
> Jeroen
>
--
Sven de Marothy <[EMAIL PROTECTED]>
Index: java/lang/String.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/String.java,v
retrieving revision 1.62
diff -u -r1.62 String.java
--- java/lang/String.java 15 Apr 2005 16:13:34 -0000 1.62
+++ java/lang/String.java 18 Apr 2005 10:08:29 -0000
@@ -112,14 +112,14 @@
* Characters which make up the String.
* Package access is granted for use by StringBuffer.
*/
- public final char[] value;
+ private final char[] value;
/**
* Holds the number of characters in value. This number is generally
* the same as value.length, but can be smaller because substrings and
* StringBuffers can share arrays. Package visible for use by trusted code.
*/
- public final int count;
+ private final int count;
/**
* Caches the result of hashCode(). If this value is zero, the hashcode
@@ -132,7 +132,7 @@
* substring()'s are common, the use of offset allows the operation
* to perform in O(1). Package access is granted for use by StringBuffer.
*/
- public final int offset;
+ private final int offset;
/**
* An implementation for [EMAIL PROTECTED] CASE_INSENSITIVE_ORDER}.
_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches