On Tue, May 24, 2005 at 09:18:38PM -0400, Thomas Fitzsimmons wrote: > Hi, > > This patch fixes a long-standing bug in the GTK scrollbar peer. The > proper fix required some GTK work: > > http://bugzilla.gnome.org/show_bug.cgi?id=133263 > > The patch there landed in GTK 2.6. The attached patch, which I > committed to GNU Classpath HEAD, changes the configure check to require > GTK 2.6 and takes advantage of the new "change-value" signal. This > fixes two aspects of scrolling: > > - adjustment types are now supported properly (UNIT_INCREMENT/DECREMENT, > BLOCK_INCREMENT/DECREMENT and TRACK type adjustments). > > - setting a scrollbar's value works, without causing a callback loop > (callback loops cause strange behaviour, where e.g. two scrollbars > linked together will start oscillating crazily forever as soon as one is > adjusted) > > Tom > > 2005-05-24 Thomas Fitzsimmons <[EMAIL PROTECTED]> > > * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkScrollBarPeer.c > (connectSignals): Connect to new change-value signal. > (post_change_event): Remove signal handler. > (slider_moved_cb): New signal handler. > * configure.ac: Require gtk+-2.0 >= 2.6.
Please announce such updates on [email protected] before commiting so people can update their GTK. Another thing you missed was updating the NEWS and INSTALL files to tell the people what minimum requirements we have now. Michael -- Escape the Java Trap with GNU Classpath! http://www.gnu.org/philosophy/java-trap.html Join the community at http://planet.classpath.org/ _______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
