On Wed, 2005-06-29 at 14:39 -0600, Tom Tromey wrote:
> >>>>> "Aaron" == Aaron Luchko <[EMAIL PROTECTED]> writes:
>
> Aaron> Okay, this is the first implementation of a CommandSet.
>
> This seems reasonable enough to me. A few nits though...
>
> Aaron> The reason I'm still using a switch in this class
> Aaron> even though there's only a single command to choose from is consistency
> Aaron> with the rest of the CommandSets.
>
> Rationale like this should go in comments in the code.
Alright
>
> Aaron> One additional thing I was wondering about is the comments for classes
> Aaron> implementing an interface. There's nothing specific about any of the
> Aaron> runCommands that should require a specific javadoc and running javadoc
> Aaron> will pick up the command of the interface defining the method if there
> Aaron> isn't a comment where it's implemented. However that will mean there
> Aaron> won't be any comments when one's looking at the actual code.
>
> I wouldn't worry about this.
Cool I'll just leave them out then.
> Aaron> + case JdwpConstants.CommandSet.StringReference.Value:
>
> Constants should be all upper case; this is just a general java style
> rule that everybody follows.
Here's the updated patch
Aaron
ChangeLog
2005-07-04 Aaron Luchko <[EMAIL PROTECTED]>
* gnu/classpath/jdwp/processor/StringReferenceCommandSet.java:
New file.
--- /dev/null 2005-06-09 16:29:11.371620296 -0400
+++ gnu/classpath/jdwp/processor/StringReferenceCommandSet.java 2005-07-04 12:34:08.000000000 -0400
@@ -0,0 +1,98 @@
+/* StringReferenceCommandSet.java -- class to implement the StringReference
+ Command Set
+ Copyright (C) 2005 Free Software Foundation
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING. If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library. Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module. An independent module is a module which is not derived from
+or based on this library. If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so. If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package gnu.classpath.jdwp.processor;
+
+import gnu.classpath.jdwp.Jdwp;
+import gnu.classpath.jdwp.JdwpConstants;
+import gnu.classpath.jdwp.exception.JdwpException;
+import gnu.classpath.jdwp.exception.JdwpInternalErrorException;
+import gnu.classpath.jdwp.exception.NotImplementedException;
+import gnu.classpath.jdwp.id.ObjectId;
+import gnu.classpath.jdwp.util.JdwpString;
+
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+
+/**
+ * A class representing the StringReference Command Set.
+ *
+ * @author Aaron Luchko <[EMAIL PROTECTED]>
+ */
+public class StringReferenceCommandSet implements CommandSet
+{
+
+ public boolean runCommand(ByteBuffer bb, DataOutputStream os, byte command)
+ throws JdwpException
+ {
+ try
+ {
+
+ // Although there's only a single command to choose from we still use
+ // a switch to maintain consistency with the rest of the CommandSets
+ switch (command)
+ {
+ case JdwpConstants.CommandSet.StringReference.VALUE:
+ executeValue(bb, os);
+ break;
+ default:
+ throw new NotImplementedException("Command " + command +
+ " not found in String Reference Command Set.");
+ }
+ }
+ catch (IOException ex)
+ {
+ // The DataOutputStream we're using isn't talking to a socket at all
+ // So if we throw an IOException we're in serious trouble
+ throw new JdwpInternalErrorException(ex);
+ }
+ return true;
+ }
+
+ private void executeValue(ByteBuffer bb, DataOutputStream os)
+ throws JdwpException, IOException
+ {
+ ObjectId oid = Jdwp.getIdManager().readId(bb);
+
+ String str = (String) oid.getObject();
+ JdwpString.writeString(os, str);
+ }
+}
_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches
