Hi,

On Thu, 2005-08-18 at 15:41 +0200, Roman Kennke wrote:
>             public void run ()
>             {
> -             ip.startProduction (PixelGrabber.this);
> +              try
> +                {
> +                  ip.startProduction (PixelGrabber.this);
> +                }
> +              catch (Exception ex)
> +                {
> +                  ex.printStackTrace();
> +                  imageComplete(ImageConsumer.ABORTED);
> +                }
>             }
>           };

Why catch Exception and not Throwable? (You will miss notifying the
consumer when an Error is thrown). Why print the stack trace?

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to