Hi, On Fri, 2005-08-26 at 00:35 -0400, Thomas Fitzsimmons wrote: > This patch adds support for Save file dialogs in the GTK peers.
> + else
> + {
> + widget = gtk_file_chooser_dialog_new
> + ("Save File",
> + GTK_WINDOW(parentp),
> + GTK_FILE_CHOOSER_ACTION_SAVE,
> + GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
> + GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT,
> + NULL);
> + gtk_file_chooser_set_do_overwrite_confirmation
> + (GTK_FILE_CHOOSER (widget), TRUE);
> + }
That is new 2.8 functionality. I don't think we should unconditionally
depend on that.
> +Java_gnu_java_awt_peer_gtk_GtkWindowPeer_setVisibleNative
> + (JNIEnv *env, jobject obj, jboolean visible)
> +{
> + gdk_threads_enter ();
> +
> + Java_gnu_java_awt_peer_gtk_GtkWindowPeer_setVisibleNativeUnlocked
> + (env, obj, visible);
> +
> + gdk_threads_leave ();
> +}
> +
> +JNIEXPORT void JNICALL
> +Java_gnu_java_awt_peer_gtk_GtkWindowPeer_setVisibleNativeUnlocked
> + (JNIEnv *env, jobject obj, jboolean visible)
> +{
> + void *ptr;
> +
> + ptr = NSA_GET_PTR (env, obj);
> +
> + if (visible)
> + gtk_widget_show (GTK_WIDGET (ptr));
> + else
> + gtk_widget_hide (GTK_WIDGET (ptr));
> +
> + gdk_flush ();
> +}
Is the gdk_flush () really needed in the Unlocked case?
I think you only need that just before the gdk_threads_leave ().
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
