On Wed, Oct 19, 2005 at 08:46:16PM +0200, Roman Kennke wrote:
> Hi Micheal,
>
> > > -public class CannotRedoException
> > > - extends RuntimeException
> > > +public class CannotRedoException extends RuntimeException
> > > {
> >
> > The old version is according to our formatting rules. The new version is
> > not.
>
> Well, last time I asked about that on IRC I was told (by tromey AFAIR)
> that the new version is correct.
Don't ask on IRC, read the documentation. ;-)
>From the hacking guide (hacking.texinfo):
Wrap always before extends, implements, throws, and labels.
> > > /**
> > > * Constructs a new instance of a <code>CannotRedoException</code>.
> > > */
> > > public CannotRedoException()
> > > {
> > > + super();
> > > }
> >
> > You know that this is implicit and not needed. We try to avoid implicit
> > stuff.
>
> Yeah, I had the choice between calling super() and adding a comment.
> Calling super() seemed more natural to me. If it's agreed that super();
> should be avoided, then I'll replace it with a comment instead.
I would prefer a comment here.
Cheers,
Michael
--
Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
Join the community at http://planet.classpath.org/
_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches
