Hi Nicolas, On Fri, 2005-10-28 at 11:29 +0200, Nicolas Geoffray wrote: > 2005-10-28 Nicolas Geoffray <[EMAIL PROTECTED]> > > Reported by: Gael Thomas <[EMAIL PROTECTED]> > * NEWS : added entry about new implementation of > VMClassLoader.getPackage(s), and new method > VMClassLoader.getBootPackages > * vm/reference/java/lang/VMClassLoader.java: > Added new definedPackages field to store packages > loaded by the bootstrap classloader. > Added new static initializer to create all packages > which names are returned by getBootPackages > (getBootPackages): new private method. Helper > to get as a String[] the native package names > (getPackage): uses the new definedPackages field > (getPackages): uses the new definedPackages field > * java/lang/Class.java: > (getPackage): if the classloader of the class is null > then call VMClassLoader.getPackage
Thanks. Looks great (and it works fine here). Two small nitpicks for
next time (nothing major, just to keep the style consistent over time
between different developers).
- Please make the change log entries full sentences
starting with a capital letter, ending with a dot.
- Please commit a change like this in one go that makes relating the
commit messages to the actual change a little easier. So in this case:
cvs commit ChangeLog NEWS java/lang/Class.java \
vm/reference/java/lang/VMClassLoader.java
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
