Am Mittwoch, den 26.10.2005, 15:26 +0200 schrieb Jeroen Frijters:
> Roman Kennke wrote:
> > Ingo found a bug in the Windows path handling. In the PlatformHelper
> > class we lowercase all Windows paths. This is kind of naive and
> > shortsighted, because paths are not only file system paths, 
> > but can also be paths inside JAR files etc, which actually ARE
> > case-sensitive.
> 
> When I last looked at PlatformHelper, it was very broken (on Windows)
> and I recommend not using it at all. IMHO it should be removed from cvs
> and VMFile should be rewritten to delegate these operations to native
> code.
> 
> IKVM replaces VMFile, so for me it's not really important, but it would
> be good for other VMs to have better Windows support.

Ok, I'll commit this now.

2005-11-09  Roman Kennke  <[EMAIL PROTECTED]>

        Reported by Ingo Proetel  <[EMAIL PROTECTED]>
        * gnu/java/io/PlatformHelper.java
        (toCanonicalForm): Remove lowercasing of paths in Windows. This
        breaks working with URLs, like when accessing files withing JAR
        files.

/Roman

Index: gnu/java/io/PlatformHelper.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/io/PlatformHelper.java,v
retrieving revision 1.5
diff -u -r1.5 PlatformHelper.java
--- gnu/java/io/PlatformHelper.java	2 Jul 2005 20:32:12 -0000	1.5
+++ gnu/java/io/PlatformHelper.java	9 Nov 2005 22:45:47 -0000
@@ -109,11 +109,6 @@
     String tmppath = path.replace('/', separatorChar);
     StringBuffer canonpath;
 
-    // We found it'll be more efficient and easy to handle to
-    // return a lowercased canonical path
-    if(isWindows)
-      tmppath = tmppath.toLowerCase();
-
     int i;
 
     if ((i = beginWithRootPathPrefix(tmppath)) == 0 )

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to