Mark Wielaard wrote: > On Wed, 2005-11-09 at 21:16 +0000, Roman Kennke wrote: > > Ingo has abstracted out the native code from > gnu.java.net.PlainSocketImpl > > and gnu.java.net.PlainDatagramSocketImpl into a new VM > interface. This > > allows VM implementors to provide a different implementation for the > > native parts of these classes if they wish. Is this ok to > commit as it > > is? Do you have any suggestions/improvements to the > interface? We would > > like to have a stable VM interface for this area, so maybe > it would be > > helpful to discuss this with other VM implementors... > > Great idea! This is one area where there is a large divergence between > classpath and libgcj because we never had VMClasses here. > IKVM also has a completely different implementation of these classes. > So I hope Jeroen also can take a look.
This doesn't work for me and I don't see much room for improvement over my current scheme of totally replacing Plain[Datagram]SocketImpl. There is no common code between the generic GNU Classpath version and my version, so I don't gain much from sharing this class (this is not a bad thing BTW, it just means that Sun did a good job designed the SocketImpl interface, which was after all intended to plug in different implementations). Regards, Jeroen _______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
