Hi Lillian, I would prefer the more efficient (and more correct?) solution and fix the viewToModel() methods. I don't really care if it doesn't work yet because of the viewToModel() methods not working properly, this way we have some more reasons to fix those.
Also, in JTextComponent you directly create KeyBindings for the new Actions. This doesn't sound right, IMO this should be done by the UI (BasicTextUI). The UIDefaults should have an array of InputMap-like bindings (e.g. in TextField.focusInputMap) that should then be loaded into an InputMap (using LookAndFeel.loadKeyBindings()) and installed in the text component (using SwingUtilities.replaceUIInputMap()). Direct key bindings are not what we want. Could you please fix that? (At least the keybinding thing?) Also note that there is a getActionMap() method in BasicTextUI that really shouldn't be there. We should figure out how to properly install an ActionMap on the text component, I would think that we fetch getActions() from JTextComponent and create an ActionMap out of it by fetching the NAME from the Action instances and put them into an ActionMap using the NAME as key. Cheers, Roman
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
_______________________________________________ Classpath-patches mailing list [email protected] http://lists.gnu.org/mailman/listinfo/classpath-patches
