>>>>> "Chris" == Chris Burdess <[EMAIL PROTECTED]> writes:

Chris> Please comment.

Chris> -        dst[dstIndex + 1] = (char) ((codePoint & 0x3ff)
Chris> -                                    + (int) MIN_LOW_SURROGATE );
Chris> -        dst[dstIndex] = (char) ((codePoint >> 10) + (int) 
MIN_HIGH_SURROGATE);
Chris> +        dst[dstIndex + 1] = (char) (((codePoint - 0x10000) % 0x400) + 
0xdc00);
Chris> +        dst[dstIndex] = (char) (((codePoint - 0x10000) / 0x400) + 
0xd800);

I think it is better to use the named constants instead of the values.

I also have a mild preference for the bit-shifting and masking
computation, but this is more minor.

Tom


_______________________________________________
Classpath-patches mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to