Hi Robert, On Tue, 2006-01-24 at 18:07 +0100, Robert Schuster wrote: > The funny thing is that the whole behavior depends on three places. Two of > them > were implemented already because they are part of the spec. The final > component > consists only of one line (calling super.inititialize() in > DefaultPersistenceDelegate.initialize()).
This cleans up the code very nicely. Good catch!
> 2006-01-24 Robert Schuster <[EMAIL PROTECTED]>
>
> * java/beans/XMLEncoder.java:
> (writeExpression): Added early return (fixes PR #25941).
> * java/beans/Encoder: Removed unused imports.
> (setupDefaultPersistenceDelegates): Removed unneccessary
> PersistenceDelegates for subclasses.
> * java/beans/PersistenceDelegate:
> (initialize): Use local variable as first argument as it was
> intended once.
There was also this small change:
> diff -u -r1.1 Encoder.java
> --- java/beans/Encoder.java 8 Jan 2006 19:31:38 -0000 1.1
> +++ java/beans/Encoder.java 24 Jan 2006 16:42:17 -0000
> @@ -199,7 +173,6 @@
> public void exceptionThrown(Exception e)
> {
> System.err.println("exception thrown: " + e);
> - e.printStackTrace();
> }
> };
> }
Was that deliberate? And would it be a good idea to actually use a
gnu.java.beans.decoder.DefaultExceptionListener here? And while I am
suggesting changes, might it be a good idea to add a static
getInstance() method to DefaultExceptionListener so we don't need to
create a new Object each time and share the listener between all
Decoders?
Cheers,
Mark
signature.asc
Description: This is a digitally signed message part
