Hi Raif, On Mon, 2006-01-30 at 19:57 +1100, Raif S. Naffah wrote: > this patch designates gnu.java.security.jce.sig.DSSKeyPairGeneratorSpi > as the implementation of DSS (alias DSA), effectively crippling > gnu.java.security.provider.DSAKeyPairGenerator.
I am not an expert on the different implementations of this algorithm. But if you and Casey agree on this and there are some test results that show no regressions then I would say go for it. It would be good to document all the duplications of algorithms and suggestions/decisions how to resolve them in the bug report that Casey opened about it: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26012 > diff -u -r1.11 Gnu.java > --- Gnu.java 26 Jan 2006 02:25:08 -0000 1.11 > +++ Gnu.java 30 Jan 2006 08:52:04 -0000 > @@ -105,8 +105,8 @@ > put("Signature.RSA-PSS/RAW ImplementedIn", "Software"); > > // Key Pair Generator > - put("KeyPairGenerator.DSA", > - gnu.java.security.provider.DSAKeyPairGenerator.class.getName()); > +// put("KeyPairGenerator.DSA", > +// > gnu.java.security.provider.DSAKeyPairGenerator.class.getName()); > put("KeyPairGenerator.DiffieHellman", > DiffieHellmanKeyPairGeneratorImpl.class.getName ()); Please just remove code don't comment it out. The history can be found in CVS and commented out code (without any comment why!) is just confusing to the reader. And if no code inside out core library directly accesses gnu.java.security.provider.DSAKeyPairGenerator now then I think you should just remove it. Cheers, Mark
signature.asc
Description: This is a digitally signed message part
