On Mon, 2006-02-13 at 16:29 +0100, Mark Wielaard wrote: > Hi, > > To better understand the gtk+ peers I documented GtkGenericPeer a little > to make it more clear what should be overridden and why. I also cleaned > up the setting of fonts of the Menu peers so they look better even when > the user has set a custom (font) theme. While documenting this change I > also noticed that the GtkTextFieldPeer was using a custom way to set the > widget font which was similar to what was already done by > GtkGenericPeer. > > 2006-02-13 Mark Wielaard <[EMAIL PROTECTED]> > > * gnu/java/awt/peer/gtk/GtkGenericPeer.java (awtWidget): Made field > final. > (gtkWidgetModifyFont(Font)): New protected helper method. > (gtkWidgetModifyFont(String,int,int)): Made protected and document. > * gnu/java/awt/peer/gtk/GtkButtonPeer.java (gtkWidgetModifyFont): > Made protected and document. > * gnu/java/awt/peer/gtk/GtkCheckboxPeer.java (gtkWidgetModifyFont): > Likewise. > * gnu/java/awt/peer/gtk/GtkLabelPeer.java (gtkWidgetModifyFont): > Likewise. > * gnu/java/awt/peer/gtk/GtkListPeer.java (gtkWidgetModifyFont): > Likewise. > * gnu/java/awt/peer/gtk/GtkMenuBarPeer.java (create): Made protected. > (setFont): Removed method. Done in GtkMenuComponent. > * gnu/java/awt/peer/gtk/GtkMenuComponentPeer.java (create): Made > abstract and protected. > (setFont): Made private, add implementation. > (setFont(Font)): Implemented. > * gnu/java/awt/peer/gtk/GtkMenuItemPeer.java (gtkWidgetModifyFont): > Made protected and document. > (create): Made protected. > (setFont): Removed method. Done in GtkMenuComponent. > * gnu/java/awt/peer/gtk/GtkTextAreaPeer.java > (gtkWidgetModifyFont): Made protected and document. > * gnu/java/awt/peer/gtk/GtkTextFieldPeer.java (gtkWidgetModifyFont): > Removed, similar to GtkGenericPeer super class implementation. > * include/gnu_java_awt_peer_gtk_GtkTextFieldPeer.h: Regenerated. > * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextFieldPeer.c > (Java_gnu_java_awt_peer_gtk_GtkTextFieldPeer_gtkWidgetModifyFont): > Removed. > > Comments? OK to commit?
Looks good, please commit. Thanks, Tom > > Tested against the vte and some local test programs on both menus and > textfields to make sure fonts are handles correctly. > > Thanks, > > Mark
