Roman Kennke wrote:

Hi David,

Am Dienstag, den 14.02.2006, 11:37 +0000 schrieb David Gilbert:
The JComponent.getListeners(Class) method doesn't return any PropertyChangeListeners that have been added to a JComponent. However, I modified the Mauve test for this method to show that the reference implementation does return the PropertyChangeListeners, so I propose this patch to make it work:

2006-02-14  David Gilbert  <[EMAIL PROTECTED]>

        * javax/swing/JComponent.java
        (getListeners): Check for PropertyChangeListener.class and delegate to
        getPropertyChangeListeners() for that case.

OK to commit?

Sure. Thanks for finding and fixing this. And for the Mauve test of
course :-)

/Roman

Committed, thanks.

Regards,

Dave
Index: javax/swing/JComponent.java
===================================================================
RCS file: /sources/classpath/classpath/javax/swing/JComponent.java,v
retrieving revision 1.99
diff -u -r1.99 JComponent.java
--- javax/swing/JComponent.java 13 Feb 2006 22:29:04 -0000      1.99
+++ javax/swing/JComponent.java 14 Feb 2006 15:18:44 -0000
@@ -1,5 +1,5 @@
 /* JComponent.java -- Every component in swing inherits from this class.
-   Copyright (C) 2002, 2004, 2005  Free Software Foundation, Inc.
+   Copyright (C) 2002, 2004, 2005, 2006,  Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -763,7 +763,10 @@
    */
   public EventListener[] getListeners(Class listenerType)
   {
-    return listenerList.getListeners(listenerType);
+    if (listenerType == PropertyChangeListener.class)
+      return getPropertyChangeListeners();
+    else
+      return listenerList.getListeners(listenerType);
   }
 
   /**

Reply via email to