Hi,

On Wed, 2006-02-15 at 00:12 +0100, Michael Koch wrote:
> 2006-02-15  Michael Koch  <[EMAIL PROTECTED]>
> 
>       * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c
>       (Java_gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer_create):
>       Make sure the embedded window gets no decorations.
>       * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c
>       (window_get_frame_extents): Return early of the window has no
>       decorations.

This introduced a small compile error with --enable-Werror. Please use
this configure option always when hacking on any C code. It isn't the
default since there are some systems where there are some warnings in
system headers, but on most modern systems we really shouldn't have any
C compiler warnings. And they almost always point out a possible
(portability) issue.

Fixed as follows:

2006-02-15  Mark Wielaard  <[EMAIL PROTECTED]>

    * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c
    (Java_gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer_create):
    gtk_plug_new() returns a GtkWindow.

Committed,

Mark
Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c,v
retrieving revision 1.8
diff -u -r1.8 gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c	15 Feb 2006 09:00:25 -0000	1.8
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.c	15 Feb 2006 12:07:58 -0000
@@ -44,14 +44,14 @@
 Java_gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer_create
   (JNIEnv *env, jobject obj, jlong socket_id)
 {
-  GtkWidget *window;
+  GtkWindow *window;
   GtkWidget *fixed;
 
   gdk_threads_enter ();
 
   NSA_SET_GLOBAL_REF (env, obj);
 
-  window = gtk_plug_new ((GdkNativeWindow) socket_id);
+  window = GTK_WINDOW (gtk_plug_new ((GdkNativeWindow) socket_id));
 
   gtk_window_set_decorated (window, FALSE);
 

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to